[PATCH 2/2] pinctrl: nomadik: mark GPIO lines used for IRQ

[PATCH 2/2] pinctrl: nomadik: mark GPIO lines used for IRQ

[Linus Walleij]

When an IRQ is started on a GPIO line, mark this GPIO as IRQ in
the gpiolib so we can keep track of the usage centrally.

Cc: Enric Balletbo i Serra <eballetbo@gmail.com>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/pinctrl/pinctrl-nomadik.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/pinctrl/pinctrl-nomadik.c b/drivers/pinctrl/pinctrl-nomadik.c
index d7c3ae3..7111c3b 100644
--- a/drivers/pinctrl/pinctrl-nomadik.c
+++ b/drivers/pinctrl/pinctrl-nomadik.c
@@ -634,6 +634,10 @@ static unsigned int nmk_gpio_irq_startup(struct irq_data *d)
 {
 	struct nmk_gpio_chip *nmk_chip = irq_data_get_irq_chip_data(d);
 
+	if (gpio_lock_as_irq(&nmk_chip->chip, d->hwirq))
+		dev_err(nmk_chip->chip.dev,
+			"unable to lock HW IRQ %lu for IRQ\n",
+			d->hwirq);
 	clk_enable(nmk_chip->clk);
 	nmk_gpio_irq_unmask(d);
 	return 0;
@@ -645,6 +649,7 @@ static void nmk_gpio_irq_shutdown(struct irq_data *d)
 
 	nmk_gpio_irq_mask(d);
 	clk_disable(nmk_chip->clk);
+	gpio_unlock_as_irq(&nmk_chip->chip, d->hwirq);
 }
 
 static struct irq_chip nmk_gpio_irq_chip = {
-- 
1.8.3.1

Re: [PATCH 2/2] pinctrl: nomadik: mark GPIO lines used for IRQ

[Stephen Warren]

On 10/11/2013 03:32 AM, Linus Walleij wrote:
> When an IRQ is started on a GPIO line, mark this GPIO as IRQ in
> the gpiolib so we can keep track of the usage centrally.

Are you planning on converting all GPIO+IRQ drivers, or should others
port this fix?

Re: [PATCH 2/2] pinctrl: nomadik: mark GPIO lines used for IRQ

[Javier Martinez Canillas]

> On 11/10/2013, at 21:17, Stephen Warren <swarren@wwwdotorg.org> wrote:
> 
>> On 10/11/2013 03:32 AM, Linus Walleij wrote:
>> When an IRQ is started on a GPIO line, mark this GPIO as IRQ in
>> the gpiolib so we can keep track of the usage centrally.
> 
> Are you planning on converting all GPIO+IRQ drivers, or should others
> port this fix?

FWIW I have already a patch to convert gpio-omap to use this API instead of custom code and will post it as soon as Linus' patch is merged on one of his branches.

Best regards,
Javier

Re: [PATCH 2/2] pinctrl: nomadik: mark GPIO lines used for IRQ

[Jean-Christophe PLAGNIOL-VILLARD]

On 13:17 Fri 11 Oct     , Stephen Warren wrote:
> On 10/11/2013 03:32 AM, Linus Walleij wrote:
> > When an IRQ is started on a GPIO line, mark this GPIO as IRQ in
> > the gpiolib so we can keep track of the usage centrally.
> 
> Are you planning on converting all GPIO+IRQ drivers, or should others
> port this fix?

I plan to do so
I propose this at ELCE and more cleanup

Best Regards,
J.

Re: [PATCH 2/2] pinctrl: nomadik: mark GPIO lines used for IRQ

[Linus Walleij]

On Fri, Oct 11, 2013 at 9:17 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 10/11/2013 03:32 AM, Linus Walleij wrote:
>> When an IRQ is started on a GPIO line, mark this GPIO as IRQ in
>> the gpiolib so we can keep track of the usage centrally.
>
> Are you planning on converting all GPIO+IRQ drivers, or should others
> port this fix?

Hm I think I will post patches for "my" GPIO drivers that I can test, and
try to set a good example. If nothing happens I guess I have to go in and try
to enforce it.

A tested patch to gpio-tegra.c would be appreciated :-)

My "devel" branch should be out today for those who want a
baseline to test against.

Yours,
Linus Walleij