* [PATCH] gpio: adnp: rename "virq" to "child_irq"
@ 2013-10-11 17:11 Linus Walleij
2013-10-14 9:25 ` Lars Poeschel
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2013-10-11 17:11 UTC (permalink / raw)
To: linux-gpio; +Cc: Alexandre Courbot, Linus Walleij, Lars Poeschel
This variable is confusingly named, the different Linux IRQs
aren't any more virtual than any other Linux IRQ. Give it a
non-misleading name.
Cc: Lars Poeschel <poeschel@lemonage.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/gpio/gpio-adnp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-adnp.c b/drivers/gpio/gpio-adnp.c
index 6439e0e..b204033 100644
--- a/drivers/gpio/gpio-adnp.c
+++ b/drivers/gpio/gpio-adnp.c
@@ -325,9 +325,9 @@ static irqreturn_t adnp_irq(int irq, void *data)
pending &= isr & ier;
for_each_set_bit(bit, &pending, 8) {
- unsigned int virq;
- virq = irq_find_mapping(adnp->domain, base + bit);
- handle_nested_irq(virq);
+ unsigned int child_irq;
+ child_irq = irq_find_mapping(adnp->domain, base + bit);
+ handle_nested_irq(child_irq);
}
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] gpio: adnp: rename "virq" to "child_irq"
2013-10-11 17:11 [PATCH] gpio: adnp: rename "virq" to "child_irq" Linus Walleij
@ 2013-10-14 9:25 ` Lars Poeschel
0 siblings, 0 replies; 2+ messages in thread
From: Lars Poeschel @ 2013-10-14 9:25 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-gpio, Alexandre Courbot
On Monday 14 October 2013 19:11:58, Linus Walleij wrote:
> This variable is confusingly named, the different Linux IRQs
> aren't any more virtual than any other Linux IRQ. Give it a
> non-misleading name.
>
> Cc: Lars Poeschel <poeschel@lemonage.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/gpio/gpio-adnp.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-adnp.c b/drivers/gpio/gpio-adnp.c
> index 6439e0e..b204033 100644
> --- a/drivers/gpio/gpio-adnp.c
> +++ b/drivers/gpio/gpio-adnp.c
> @@ -325,9 +325,9 @@ static irqreturn_t adnp_irq(int irq, void *data)
> pending &= isr & ier;
>
> for_each_set_bit(bit, &pending, 8) {
> - unsigned int virq;
> - virq = irq_find_mapping(adnp->domain, base + bit);
> - handle_nested_irq(virq);
> + unsigned int child_irq;
> + child_irq = irq_find_mapping(adnp->domain, base + bit);
> + handle_nested_irq(child_irq);
> }
> }
Acked-by: Lars Poeschel <poeschel@lemonage.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-14 9:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-11 17:11 [PATCH] gpio: adnp: rename "virq" to "child_irq" Linus Walleij
2013-10-14 9:25 ` Lars Poeschel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).