From: "Markus Mayer" <markus.mayer@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Linaro Patches <patches@linaro.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Linux GPIO List <linux-gpio@vger.kernel.org>,
Markus Mayer <markus.mayer@linaro.org>
Subject: [PATCH] gpio: bcm281xx: Don't print addresses of GPIO area in probe()
Date: Fri, 18 Oct 2013 11:50:03 -0700 [thread overview]
Message-ID: <1382122203-16057-1-git-send-email-markus.mayer@linaro.org> (raw)
The physical address of the GPIO memory address is already printed
implicitly by dev_info() as part of the device name. The virtual
address doesn't add any value. In addition, printing a resource_size_t
with %x lead to a compiler warning on some platforms.
Signed-off-by: Markus Mayer <markus.mayer@linaro.org>
---
This patch is dependent on:
- http://patches.linaro.org/19933/
drivers/gpio/gpio-bcm-kona.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c
index 58188ba..b3d0f81 100644
--- a/drivers/gpio/gpio-bcm-kona.c
+++ b/drivers/gpio/gpio-bcm-kona.c
@@ -587,8 +587,7 @@ static int bcm_kona_gpio_probe(struct platform_device *pdev)
}
}
- dev_info(&pdev->dev, "Setting up Kona GPIO at 0x%p (phys %#x)\n",
- kona_gpio->reg_base, res->start);
+ dev_info(&pdev->dev, "Setting up Kona GPIO\n");
bcm_kona_gpio_reset(kona_gpio);
--
1.7.9.5
next reply other threads:[~2013-10-18 18:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 18:50 Markus Mayer [this message]
2013-10-18 19:45 ` [PATCH] gpio: bcm281xx: Don't print addresses of GPIO area in probe() Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382122203-16057-1-git-send-email-markus.mayer@linaro.org \
--to=markus.mayer@linaro.org \
--cc=acourbot@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).