* [PATCH 3/4] pinctrl: at91: copy define to driver
@ 2013-11-05 9:30 Linus Walleij
2013-11-05 9:52 ` Nicolas Ferre
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2013-11-05 9:30 UTC (permalink / raw)
To: linux-gpio, Andrew Victor, Nicolas Ferre,
Jean-Christophe Plagniol-Villard
Cc: Alexandre Courbot, linux-arm-kernel, Linus Walleij
The #define for the maximum number of GPIO blocks was retrieved
into pinctrl-at91.c by implicit inclusion of <mach/gpio.h>
from <linux/gpio.h> creating a dependency on machine-local
<mach/gpio.h>. Break the depenency by copying this single
define into the driver.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
This will be applied directly to the pinctrl tree unless there
are specific protests.
---
drivers/pinctrl/pinctrl-at91.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
index f350fd2e170e..0dfb8c7b58df 100644
--- a/drivers/pinctrl/pinctrl-at91.c
+++ b/drivers/pinctrl/pinctrl-at91.c
@@ -33,6 +33,7 @@
#include "core.h"
+#define MAX_GPIO_BANKS 5
#define MAX_NB_GPIO_PER_BANK 32
struct at91_pinctrl_mux_ops;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 3/4] pinctrl: at91: copy define to driver
2013-11-05 9:30 [PATCH 3/4] pinctrl: at91: copy define to driver Linus Walleij
@ 2013-11-05 9:52 ` Nicolas Ferre
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Ferre @ 2013-11-05 9:52 UTC (permalink / raw)
To: Linus Walleij, linux-gpio, Andrew Victor,
Jean-Christophe Plagniol-Villard
Cc: Alexandre Courbot, linux-arm-kernel
On 05/11/2013 10:30, Linus Walleij :
> The #define for the maximum number of GPIO blocks was retrieved
> into pinctrl-at91.c by implicit inclusion of <mach/gpio.h>
> from <linux/gpio.h> creating a dependency on machine-local
> <mach/gpio.h>. Break the depenency by copying this single
> define into the driver.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Yes, that seems reasonable.
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> This will be applied directly to the pinctrl tree unless there
> are specific protests.
> ---
> drivers/pinctrl/pinctrl-at91.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
> index f350fd2e170e..0dfb8c7b58df 100644
> --- a/drivers/pinctrl/pinctrl-at91.c
> +++ b/drivers/pinctrl/pinctrl-at91.c
> @@ -33,6 +33,7 @@
>
> #include "core.h"
>
> +#define MAX_GPIO_BANKS 5
> #define MAX_NB_GPIO_PER_BANK 32
>
> struct at91_pinctrl_mux_ops;
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-05 9:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-05 9:30 [PATCH 3/4] pinctrl: at91: copy define to driver Linus Walleij
2013-11-05 9:52 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).