* Re: [PATCH v1.2] gpiolib: append SFI helpers for GPIO API [not found] <1370440690-21898-1-git-send-email-andriy.shevchenko@linux.intel.com> @ 2013-11-19 9:24 ` Linus Walleij 2013-11-19 9:27 ` Alex Courbot 0 siblings, 1 reply; 5+ messages in thread From: Linus Walleij @ 2013-11-19 9:24 UTC (permalink / raw) To: Andy Shevchenko, David Cohen, linux-gpio@vger.kernel.org, Alexandre Courbot Cc: Sathyanarayanan Kuppuswamy, Len Brown, linux-kernel@vger.kernel.org, Grant Likely, Mika Westerberg On Wed, Jun 5, 2013 at 3:58 PM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > To support some (legacy) firmwares and platforms let's make life easier for > their customers. > > This patch extracts SFI GPIO API from arch/x86/platform/mrst/mrst.c. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> So since this patch was ACKed the world has changed a bit and now I want new changes (or maybe I was tired and not paying enough attention at the time). (...) > +int sfi_get_gpio_by_name(const char *name) > +{ > + struct sfi_gpio_table_entry *pentry = sfi_gpio_table; > + int i; > + > + if (!pentry) > + return -EINVAL; > + > + for (i = 0; i < sfi_gpio_num_entry; i++, pentry++) { > + if (!strncmp(name, pentry->pin_name, SFI_NAME_LEN)) > + return pentry->pin_no; > + } > + > + return -ENODEV; > +} > +EXPORT_SYMBOL_GPL(sfi_get_gpio_by_name); Last merge window we merged the GPIO descriptor API and this is now the recommended way to handle GPIOs and it is also deployed into the ACPI and DT implementations. So I'd like the signature of this function changed to return a GPIO descriptor rather than an int so we don't stockpile more stuff to refactor. i.e.: struct gpio_desc *sfi_get_gpio_by_name(const char *name); --- /dev/null > +++ b/include/linux/sfi_gpio.h Maybe that header could move to <linux/gpio/sfi.h> instead. Alexandre what do you think? Yours, Linus Walleij ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1.2] gpiolib: append SFI helpers for GPIO API 2013-11-19 9:24 ` [PATCH v1.2] gpiolib: append SFI helpers for GPIO API Linus Walleij @ 2013-11-19 9:27 ` Alex Courbot 2013-11-19 17:32 ` David Cohen 0 siblings, 1 reply; 5+ messages in thread From: Alex Courbot @ 2013-11-19 9:27 UTC (permalink / raw) To: Linus Walleij, Andy Shevchenko, David Cohen, linux-gpio@vger.kernel.org Cc: Sathyanarayanan Kuppuswamy, Len Brown, linux-kernel@vger.kernel.org, Grant Likely, Mika Westerberg On 11/19/2013 06:24 PM, Linus Walleij wrote: > On Wed, Jun 5, 2013 at 3:58 PM, Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > >> To support some (legacy) firmwares and platforms let's make life easier for >> their customers. >> >> This patch extracts SFI GPIO API from arch/x86/platform/mrst/mrst.c. >> >> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > So since this patch was ACKed the world has changed a bit and now > I want new changes (or maybe I was tired and not paying enough > attention at the time). > > (...) >> +int sfi_get_gpio_by_name(const char *name) >> +{ >> + struct sfi_gpio_table_entry *pentry = sfi_gpio_table; >> + int i; >> + >> + if (!pentry) >> + return -EINVAL; >> + >> + for (i = 0; i < sfi_gpio_num_entry; i++, pentry++) { >> + if (!strncmp(name, pentry->pin_name, SFI_NAME_LEN)) >> + return pentry->pin_no; >> + } >> + >> + return -ENODEV; >> +} >> +EXPORT_SYMBOL_GPL(sfi_get_gpio_by_name); > > Last merge window we merged the GPIO descriptor API and this > is now the recommended way to handle GPIOs and it is also > deployed into the ACPI and DT implementations. > > So I'd like the signature of this function changed to return > a GPIO descriptor rather than an int so we don't stockpile more > stuff to refactor. > > i.e.: > struct gpio_desc *sfi_get_gpio_by_name(const char *name); > > --- /dev/null >> +++ b/include/linux/sfi_gpio.h > > Maybe that header could move to <linux/gpio/sfi.h> instead. > Alexandre what do you think? Agreed - all the GPIO drivers into drivers/gpio, all the headers into include/linux/gpio. Logical. :) Alex. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1.2] gpiolib: append SFI helpers for GPIO API 2013-11-19 9:27 ` Alex Courbot @ 2013-11-19 17:32 ` David Cohen 2013-11-20 12:55 ` Andy Shevchenko 2013-11-20 14:36 ` Andy Shevchenko 0 siblings, 2 replies; 5+ messages in thread From: David Cohen @ 2013-11-19 17:32 UTC (permalink / raw) To: Alex Courbot, Andy Shevchenko Cc: Linus Walleij, linux-gpio@vger.kernel.org, Sathyanarayanan Kuppuswamy, Len Brown, linux-kernel@vger.kernel.org, Grant Likely, Mika Westerberg On 11/19/2013 01:27 AM, Alex Courbot wrote: > On 11/19/2013 06:24 PM, Linus Walleij wrote: >> On Wed, Jun 5, 2013 at 3:58 PM, Andy Shevchenko >> <andriy.shevchenko@linux.intel.com> wrote: >> >>> To support some (legacy) firmwares and platforms let's make life >>> easier for >>> their customers. >>> >>> This patch extracts SFI GPIO API from arch/x86/platform/mrst/mrst.c. >>> >>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >> >> So since this patch was ACKed the world has changed a bit and now >> I want new changes (or maybe I was tired and not paying enough >> attention at the time). Agreed. Even my e-mail was outdated :) Updating from david.a.cohen@intel.com to david.a.cohen@linux.intel.com to avoid M$ servers. >> >> (...) >>> +int sfi_get_gpio_by_name(const char *name) >>> +{ >>> + struct sfi_gpio_table_entry *pentry = sfi_gpio_table; >>> + int i; >>> + >>> + if (!pentry) >>> + return -EINVAL; >>> + >>> + for (i = 0; i < sfi_gpio_num_entry; i++, pentry++) { >>> + if (!strncmp(name, pentry->pin_name, SFI_NAME_LEN)) >>> + return pentry->pin_no; >>> + } >>> + >>> + return -ENODEV; >>> +} >>> +EXPORT_SYMBOL_GPL(sfi_get_gpio_by_name); >> >> Last merge window we merged the GPIO descriptor API and this >> is now the recommended way to handle GPIOs and it is also >> deployed into the ACPI and DT implementations. >> >> So I'd like the signature of this function changed to return >> a GPIO descriptor rather than an int so we don't stockpile more >> stuff to refactor. >> >> i.e.: >> struct gpio_desc *sfi_get_gpio_by_name(const char *name); >> >> --- /dev/null >>> +++ b/include/linux/sfi_gpio.h >> >> Maybe that header could move to <linux/gpio/sfi.h> instead. >> Alexandre what do you think? > > Agreed - all the GPIO drivers into drivers/gpio, all the headers into > include/linux/gpio. Logical. :) Sounds nice. Andy, would you like to update the patch or should I go ahead and resend it myself? Br, David Cohen ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1.2] gpiolib: append SFI helpers for GPIO API 2013-11-19 17:32 ` David Cohen @ 2013-11-20 12:55 ` Andy Shevchenko 2013-11-20 14:36 ` Andy Shevchenko 1 sibling, 0 replies; 5+ messages in thread From: Andy Shevchenko @ 2013-11-20 12:55 UTC (permalink / raw) To: David Cohen Cc: Alex Courbot, Linus Walleij, linux-gpio@vger.kernel.org, Sathyanarayanan Kuppuswamy, Len Brown, linux-kernel@vger.kernel.org, Grant Likely, Mika Westerberg On Tue, 2013-11-19 at 09:32 -0800, David Cohen wrote: [] > >> Maybe that header could move to <linux/gpio/sfi.h> instead. > >> Alexandre what do you think? > > > > Agreed - all the GPIO drivers into drivers/gpio, all the headers into > > include/linux/gpio. Logical. :) > > Sounds nice. > Andy, would you like to update the patch or should I go ahead and > resend it myself? I already had done this, but I can't check since linux-next is broken for me. Once I tried it I send it here. -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1.2] gpiolib: append SFI helpers for GPIO API 2013-11-19 17:32 ` David Cohen 2013-11-20 12:55 ` Andy Shevchenko @ 2013-11-20 14:36 ` Andy Shevchenko 1 sibling, 0 replies; 5+ messages in thread From: Andy Shevchenko @ 2013-11-20 14:36 UTC (permalink / raw) To: David Cohen Cc: Alex Courbot, Linus Walleij, linux-gpio@vger.kernel.org, Sathyanarayanan Kuppuswamy, Len Brown, linux-kernel@vger.kernel.org, Grant Likely, Mika Westerberg On Tue, 2013-11-19 at 09:32 -0800, David Cohen wrote: > On 11/19/2013 01:27 AM, Alex Courbot wrote: > > On 11/19/2013 06:24 PM, Linus Walleij wrote: > >> On Wed, Jun 5, 2013 at 3:58 PM, Andy Shevchenko > >> <andriy.shevchenko@linux.intel.com> wrote: > >> > >>> To support some (legacy) firmwares and platforms let's make life > >>> easier for > >>> their customers. > >>> > >>> This patch extracts SFI GPIO API from arch/x86/platform/mrst/mrst.c. > >>> > >>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > >> > >> So since this patch was ACKed the world has changed a bit and now > >> I want new changes (or maybe I was tired and not paying enough > >> attention at the time). > > Agreed. Even my e-mail was outdated :) > Updating from david.a.cohen@intel.com to david.a.cohen@linux.intel.com > to avoid M$ servers. Just sent a version, though, sorry, I forgot to update your email there. -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-11-20 14:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1370440690-21898-1-git-send-email-andriy.shevchenko@linux.intel.com>
2013-11-19 9:24 ` [PATCH v1.2] gpiolib: append SFI helpers for GPIO API Linus Walleij
2013-11-19 9:27 ` Alex Courbot
2013-11-19 17:32 ` David Cohen
2013-11-20 12:55 ` Andy Shevchenko
2013-11-20 14:36 ` Andy Shevchenko
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).