[PATCH] gpiolib: add missing declarations

[PATCH] gpiolib: add missing declarations

[Alexandre Courbot]

Add missing declarations and include files to avoid warnings during
compilation of include/gpio/driver.h.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Reported-by: Stephen Warren <swarren@wwwdotorg.org>
---
 include/linux/gpio/driver.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index 82eac61..3ea2cf6 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -2,9 +2,12 @@
 #define __LINUX_GPIO_DRIVER_H
 
 #include <linux/types.h>
+#include <linux/module.h>
 
 struct device;
 struct gpio_desc;
+struct of_phandle_args;
+struct device_node;
 struct seq_file;
 
 /**
-- 
1.8.4.2

Re: [PATCH] gpiolib: add missing declarations

[Mika Westerberg]

On Sat, Nov 23, 2013 at 02:54:29PM +0900, Alexandre Courbot wrote:
> Add missing declarations and include files to avoid warnings during
> compilation of include/gpio/driver.h.

It would be good to have those warnings included in the changelog as well.

> 
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> Reported-by: Stephen Warren <swarren@wwwdotorg.org>

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Re: [PATCH] gpiolib: add missing declarations

[Alexandre Courbot]

On Mon, Nov 25, 2013 at 5:58 PM, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> On Sat, Nov 23, 2013 at 02:54:29PM +0900, Alexandre Courbot wrote:
>> Add missing declarations and include files to avoid warnings during
>> compilation of include/gpio/driver.h.
>
> It would be good to have those warnings included in the changelog as well.

As in, copy-pasting the compiler's output? Isn't the change explicit enough?

Re: [PATCH] gpiolib: add missing declarations

[Mika Westerberg]

On Mon, Nov 25, 2013 at 06:07:10PM +0900, Alexandre Courbot wrote:
> On Mon, Nov 25, 2013 at 5:58 PM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> > On Sat, Nov 23, 2013 at 02:54:29PM +0900, Alexandre Courbot wrote:
> >> Add missing declarations and include files to avoid warnings during
> >> compilation of include/gpio/driver.h.
> >
> > It would be good to have those warnings included in the changelog as well.
> 
> As in, copy-pasting the compiler's output? Isn't the change explicit enough?

If you just do 'git log' you can't see the change itself and that's where
the changelog should help. If I see some warnings when I build the kernel,
the first thing I usually do is to check 'git log' against linux-next and
see if someone has already fixed that warning (grepping the warning message
from changelog).

Re: [PATCH] gpiolib: add missing declarations

[Alex Courbot]

On 11/25/2013 06:28 PM, Mika Westerberg wrote:
> On Mon, Nov 25, 2013 at 06:07:10PM +0900, Alexandre Courbot wrote:
>> On Mon, Nov 25, 2013 at 5:58 PM, Mika Westerberg
>> <mika.westerberg@linux.intel.com> wrote:
>>> On Sat, Nov 23, 2013 at 02:54:29PM +0900, Alexandre Courbot wrote:
>>>> Add missing declarations and include files to avoid warnings during
>>>> compilation of include/gpio/driver.h.
>>>
>>> It would be good to have those warnings included in the changelog as well.
>>
>> As in, copy-pasting the compiler's output? Isn't the change explicit enough?
>
> If you just do 'git log' you can't see the change itself and that's where
> the changelog should help. If I see some warnings when I build the kernel,
> the first thing I usually do is to check 'git log' against linux-next and
> see if someone has already fixed that warning (grepping the warning message
> from changelog).

Ah, I can see several examples of what you mention indeed. Will add 
these and send a v2.

[PATCH v2] gpiolib: add missing declarations

[Alexandre Courbot]

Add declaration of 'struct of_phandle_args' to avoid the following
warning:

  In file included from arch/arm/mach-tegra/board-paz00.c:21:0:
  include/linux/gpio/driver.h:102:17: warning: 'struct of_phandle_args' declared inside parameter list
  include/linux/gpio/driver.h:102:17: warning: its scope is only this definition or declaration, which is probably not what you want

Also proactively add other definitions/includes that could be missing
in other contexts.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Reported-by: Stephen Warren <swarren@wwwdotorg.org>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
 include/linux/gpio/driver.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index 82eac610ce1a..3ea2cf6b0e6c 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -2,9 +2,12 @@
 #define __LINUX_GPIO_DRIVER_H
 
 #include <linux/types.h>
+#include <linux/module.h>
 
 struct device;
 struct gpio_desc;
+struct of_phandle_args;
+struct device_node;
 struct seq_file;
 
 /**
-- 
1.8.4.2

Re: [PATCH v2] gpiolib: add missing declarations

[Linus Walleij]

On Mon, Nov 25, 2013 at 10:34 AM, Alexandre Courbot <acourbot@nvidia.com> wrote:

> Add declaration of 'struct of_phandle_args' to avoid the following
> warning:
>
>   In file included from arch/arm/mach-tegra/board-paz00.c:21:0:
>   include/linux/gpio/driver.h:102:17: warning: 'struct of_phandle_args' declared inside parameter list
>   include/linux/gpio/driver.h:102:17: warning: its scope is only this definition or declaration, which is probably not what you want
>
> Also proactively add other definitions/includes that could be missing
> in other contexts.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> Reported-by: Stephen Warren <swarren@wwwdotorg.org>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Patch applied for fixes.

Yours,
Linus Walleij