Re: [PATCH v4 2/2] gpiolib: append SFI helpers for GPIO API

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Mon, 2013-12-09 at 15:04 +0200, Mika Westerberg wrote:
> On Mon, Dec 09, 2013 at 01:50:29PM +0200, Andy Shevchenko wrote:
> > diff --git a/drivers/gpio/gpiolib-sfi.c b/drivers/gpio/gpiolib-sfi.c
> > new file mode 100644
> > index 0000000..43db749
> > --- /dev/null
> > +++ b/drivers/gpio/gpiolib-sfi.c
> > @@ -0,0 +1,28 @@
> > +/*
> > + * Simple Firmware Interface (SFI) helpers for GPIO API
> > + *
> > + * Copyright (C) 2013, Intel Corporation
> > + * Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 as
> > + * published by the Free Software Foundation.
> > + */
> > +
> > +#include <linux/gpio/consumer.h>
> > +#include <linux/sfi.h>
> > +#include <linux/errno.h>
> > +#include <linux/err.h>
> > +
> > +#include "gpiolib.h"
> > +
> > +struct gpio_desc *sfi_get_gpiod_by_name(const char *name)
> > +{
> > +	struct sfi_gpio_table_entry *pentry;
> > +
> > +	pentry = sfi_gpio_get_entry_by_name(name);
> > +	if (IS_ERR(pentry))
> > +		return pentry;
> > +
> > +	return gpio_to_desc(pentry->pin_no);
> > +}
> 
> Do you really need add a new file just to have the above supported? I mean
> that if you place that function to drivers/gpio/gpiolib.c with the
> appropriate:
> 
> #ifdef CONFIG_SFI
> #else
> #endif
> 
> you can get rid of that file (and Kconfig + Makefile changes) completely,
> no?

I won't have linux/sfi.h in the gpiolib.c. If Linus has no objections, I
can do that of course.


-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy