* [PATCH] gpio: f7188x: set can_sleep attribute
@ 2013-12-23 13:34 Simon Guinot
2014-01-02 13:16 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Simon Guinot @ 2013-12-23 13:34 UTC (permalink / raw)
To: Linus Walleij, Grant Likely; +Cc: linux-gpio, Simon Guinot
Since request_muxed_region() is used to synchronize access on the
Super-I/O controller, then the can_sleep attribute must be set for
the f7188x GPIO chips.
Signed-off-by: Simon Guinot <simon.guinot@sequanux.org>
---
drivers/gpio/gpio-f7188x.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-f7188x.c b/drivers/gpio/gpio-f7188x.c
index 9cb8320..fc3e98a 100644
--- a/drivers/gpio/gpio-f7188x.c
+++ b/drivers/gpio/gpio-f7188x.c
@@ -135,6 +135,7 @@ static void f7188x_gpio_set(struct gpio_chip *chip, unsigned offset, int value);
.set = f7188x_gpio_set, \
.base = _base, \
.ngpio = _ngpio, \
+ .can_sleep = 1, \
}, \
.regbase = _regbase, \
}
--
1.8.5.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: f7188x: set can_sleep attribute
2013-12-23 13:34 [PATCH] gpio: f7188x: set can_sleep attribute Simon Guinot
@ 2014-01-02 13:16 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2014-01-02 13:16 UTC (permalink / raw)
To: Simon Guinot; +Cc: Grant Likely, linux-gpio@vger.kernel.org
On Mon, Dec 23, 2013 at 2:34 PM, Simon Guinot <simon.guinot@sequanux.org> wrote:
> Since request_muxed_region() is used to synchronize access on the
> Super-I/O controller, then the can_sleep attribute must be set for
> the f7188x GPIO chips.
>
> Signed-off-by: Simon Guinot <simon.guinot@sequanux.org>
> ---
> drivers/gpio/gpio-f7188x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-f7188x.c b/drivers/gpio/gpio-f7188x.c
> index 9cb8320..fc3e98a 100644
> --- a/drivers/gpio/gpio-f7188x.c
> +++ b/drivers/gpio/gpio-f7188x.c
> @@ -135,6 +135,7 @@ static void f7188x_gpio_set(struct gpio_chip *chip, unsigned offset, int value);
> .set = f7188x_gpio_set, \
> .base = _base, \
> .ngpio = _ngpio, \
> + .can_sleep = 1, \
I just recently changed this member to a bool so please
change this to = true instead and resend.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-02 13:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-23 13:34 [PATCH] gpio: f7188x: set can_sleep attribute Simon Guinot
2014-01-02 13:16 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).