* [PATCH] gpio: mcp23s08: depend on OF_GPIO
@ 2014-01-20 8:09 Linus Walleij
2014-01-22 15:05 ` Lars Poeschel
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2014-01-20 8:09 UTC (permalink / raw)
To: linux-gpio; +Cc: Alexandre Courbot, Linus Walleij, Lars Poeschel
The MCP drivers fails to compile on trial builds due to missing
Kconfig dependency on OF_GPIO. Fix it.
Cc: Lars Poeschel <poeschel@lemonage.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/gpio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 2d49784109b5..d5bd9eece408 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -717,7 +717,7 @@ config GPIO_MAX7301
config GPIO_MCP23S08
tristate "Microchip MCP23xxx I/O expander"
- depends on (SPI_MASTER && !I2C) || I2C
+ depends on (SPI_MASTER && !I2C) || I2C && OF_GPIO
help
SPI/I2C driver for Microchip MCP23S08/MCP23S17/MCP23008/MCP23017
I/O expanders.
--
1.8.4.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: mcp23s08: depend on OF_GPIO
2014-01-20 8:09 [PATCH] gpio: mcp23s08: depend on OF_GPIO Linus Walleij
@ 2014-01-22 15:05 ` Lars Poeschel
2014-01-23 8:30 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Lars Poeschel @ 2014-01-22 15:05 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-gpio, Alexandre Courbot
Hi Linus,
I saw some trouble happening as Linus Torvalds pulled my interrupt commit in.
Sorry for causing this mess.
You tried to fix my mistake with this patch. After I read Torvalds mail, I
realized that mcp23s08 driver now depends on OF_GPIO. I wonder if your patch
was the best way to fix this. I think a better way would be to not explicitly
depend on OF_GPIO rather than disabling interrupt functionality if OF_GPIO is
not selected. What I am a bit concerned about is, that we locked out non-OF
users from being able to use this driver from now on.
I seems since Linus Torvalds now pulled our patches and fixed them up, it is a
bit too late, but should we do another patch third patch, that reenables the
non-OF usage of the driver ? What do you think ?
Regards,
Lars
On Wednesday 22 January 2014 09:09:04, Linus Walleij wrote:
> The MCP drivers fails to compile on trial builds due to missing
> Kconfig dependency on OF_GPIO. Fix it.
>
> Cc: Lars Poeschel <poeschel@lemonage.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/gpio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 2d49784109b5..d5bd9eece408 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -717,7 +717,7 @@ config GPIO_MAX7301
>
> config GPIO_MCP23S08
> tristate "Microchip MCP23xxx I/O expander"
> - depends on (SPI_MASTER && !I2C) || I2C
> + depends on (SPI_MASTER && !I2C) || I2C && OF_GPIO
> help
> SPI/I2C driver for Microchip MCP23S08/MCP23S17/MCP23008/MCP23017
> I/O expanders.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: mcp23s08: depend on OF_GPIO
2014-01-22 15:05 ` Lars Poeschel
@ 2014-01-23 8:30 ` Linus Walleij
0 siblings, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2014-01-23 8:30 UTC (permalink / raw)
To: Lars Poeschel; +Cc: linux-gpio@vger.kernel.org, Alexandre Courbot
On Wed, Jan 22, 2014 at 4:05 PM, Lars Poeschel <poeschel@lemonage.de> wrote:
> After I read Torvalds mail, I
> realized that mcp23s08 driver now depends on OF_GPIO. I wonder if your patch
> was the best way to fix this.
I did this:
depends on (SPI_MASTER && !I2C) || I2C && OF_GPIO
But Torvalds realized we have to do it like this:
depends on OF_GPIO
depends on (SPI_MASTER && !I2C) || I2C
Due to some funny business in Kconfig.
> I think a better way would be to not explicitly
> depend on OF_GPIO rather than disabling interrupt functionality if OF_GPIO is
> not selected. What I am a bit concerned about is, that we locked out non-OF
> users from being able to use this driver from now on.
OK you need to think of something, if it's not causing any regressions
on some board it's no problem.
So user stories are needed to justify this as a regression fix.
> I seems since Linus Torvalds now pulled our patches and fixed them up, it is a
> bit too late, but should we do another patch third patch, that reenables the
> non-OF usage of the driver ? What do you think ?
That will be for the next merge window in that case.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-23 8:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-20 8:09 [PATCH] gpio: mcp23s08: depend on OF_GPIO Linus Walleij
2014-01-22 15:05 ` Lars Poeschel
2014-01-23 8:30 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).