From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Cohen Subject: [PATCH v2] gpio-intel-mid: fix the incorrect return of idle callback Date: Fri, 31 Jan 2014 13:08:01 -0800 Message-ID: <1391202481-19533-1-git-send-email-david.a.cohen@linux.intel.com> References: <20140131205007.GB26770@psi-dev26.jf.intel.com> Return-path: In-Reply-To: <20140131205007.GB26770@psi-dev26.jf.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: linus.walleij@linaro.org, gnurou@gmail.com Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, "xinhui.pan" , "bo.he" , David Cohen , Felibe Balbi List-Id: linux-gpio@vger.kernel.org From: "xinhui.pan" intel_gpio_runtime_idle should return correct error code if it do fail. make it more correct even though -EBUSY is the most possible return value. Signed-off-by: bo.he Signed-off-by: xinhui.pan Signed-off-by: David Cohen Cc: Felibe Balbi --- drivers/gpio/gpio-intel-mid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-intel-mid.c b/drivers/gpio/gpio-intel-mid.c index 41218e93b9fe..55688d0548e9 100644 --- a/drivers/gpio/gpio-intel-mid.c +++ b/drivers/gpio/gpio-intel-mid.c @@ -369,8 +369,8 @@ static const struct irq_domain_ops intel_gpio_irq_ops = { static int intel_gpio_runtime_idle(struct device *dev) { - pm_schedule_suspend(dev, 500); - return -EBUSY; + int err = pm_schedule_suspend(dev, 500); + return err ?: -EBUSY; } static const struct dev_pm_ops intel_gpio_pm_ops = { -- 1.8.4.2