* [PATCH 1/2] gpio: adp5588 - use "unsigned" for the setup and teardown callbacks
@ 2014-02-10 17:24 Jean-Francois Dagenais
2014-02-10 17:24 ` [PATCH 2/2] gpio: adp5588 - add support for gpio names Jean-Francois Dagenais
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jean-Francois Dagenais @ 2014-02-10 17:24 UTC (permalink / raw)
To: michael.hennerich, dmitry.torokhov, dtor, linus.walleij, gnurou
Cc: linux-gpio, linux-input, Jean-Francois Dagenais
to comply with the rest of the GPIO drivers.
Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
---
include/linux/i2c/adp5588.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/i2c/adp5588.h b/include/linux/i2c/adp5588.h
index d8341cb..c215304 100644
--- a/include/linux/i2c/adp5588.h
+++ b/include/linux/i2c/adp5588.h
@@ -161,10 +161,10 @@ struct adp5588_gpio_platform_data {
unsigned irq_base; /* interrupt base # */
unsigned pullup_dis_mask; /* Pull-Up Disable Mask */
int (*setup)(struct i2c_client *client,
- int gpio, unsigned ngpio,
+ unsigned gpio, unsigned ngpio,
void *context);
int (*teardown)(struct i2c_client *client,
- int gpio, unsigned ngpio,
+ unsigned gpio, unsigned ngpio,
void *context);
void *context;
};
--
1.8.5.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] gpio: adp5588 - add support for gpio names
2014-02-10 17:24 [PATCH 1/2] gpio: adp5588 - use "unsigned" for the setup and teardown callbacks Jean-Francois Dagenais
@ 2014-02-10 17:24 ` Jean-Francois Dagenais
2014-02-10 20:17 ` Hennerich, Michael
2014-02-13 12:53 ` Linus Walleij
2014-02-10 20:16 ` [PATCH 1/2] gpio: adp5588 - use "unsigned" for the setup and teardown callbacks Hennerich, Michael
2014-02-13 12:52 ` Linus Walleij
2 siblings, 2 replies; 6+ messages in thread
From: Jean-Francois Dagenais @ 2014-02-10 17:24 UTC (permalink / raw)
To: michael.hennerich, dmitry.torokhov, dtor, linus.walleij, gnurou
Cc: linux-gpio, linux-input, Jean-Francois Dagenais
which is already found in the common header for adp5588
Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
---
drivers/gpio/gpio-adp5588.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-adp5588.c b/drivers/gpio/gpio-adp5588.c
index 7d3c8d9..d974020 100644
--- a/drivers/gpio/gpio-adp5588.c
+++ b/drivers/gpio/gpio-adp5588.c
@@ -397,6 +397,7 @@ static int adp5588_gpio_probe(struct i2c_client *client,
gc->ngpio = ADP5588_MAXGPIO;
gc->label = client->name;
gc->owner = THIS_MODULE;
+ gc->names = pdata->names;
mutex_init(&dev->lock);
--
1.8.5.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH 2/2] gpio: adp5588 - add support for gpio names
2014-02-10 17:24 ` [PATCH 2/2] gpio: adp5588 - add support for gpio names Jean-Francois Dagenais
@ 2014-02-10 20:17 ` Hennerich, Michael
2014-02-13 12:53 ` Linus Walleij
1 sibling, 0 replies; 6+ messages in thread
From: Hennerich, Michael @ 2014-02-10 20:17 UTC (permalink / raw)
To: Jean-Francois Dagenais, dmitry.torokhov@gmail.com, dtor@mail.ru,
linus.walleij@linaro.org, gnurou@gmail.com
Cc: linux-gpio@vger.kernel.org, linux-input@vger.kernel.org
-----Original Message-----
From: Jean-Francois Dagenais [mailto:jeff.dagenais@gmail.com]
Sent: Montag, 10. Februar 2014 18:24
To: Hennerich, Michael; dmitry.torokhov@gmail.com; dtor@mail.ru; linus.walleij@linaro.org; gnurou@gmail.com
Cc: linux-gpio@vger.kernel.org; linux-input@vger.kernel.org; Jean-Francois Dagenais
Subject: [PATCH 2/2] gpio: adp5588 - add support for gpio names
which is already found in the common header for adp5588
Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
---
drivers/gpio/gpio-adp5588.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-adp5588.c b/drivers/gpio/gpio-adp5588.c index 7d3c8d9..d974020 100644
--- a/drivers/gpio/gpio-adp5588.c
+++ b/drivers/gpio/gpio-adp5588.c
@@ -397,6 +397,7 @@ static int adp5588_gpio_probe(struct i2c_client *client,
gc->ngpio = ADP5588_MAXGPIO;
gc->label = client->name;
gc->owner = THIS_MODULE;
+ gc->names = pdata->names;
mutex_init(&dev->lock);
--
1.8.5.3
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] gpio: adp5588 - add support for gpio names
2014-02-10 17:24 ` [PATCH 2/2] gpio: adp5588 - add support for gpio names Jean-Francois Dagenais
2014-02-10 20:17 ` Hennerich, Michael
@ 2014-02-13 12:53 ` Linus Walleij
1 sibling, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2014-02-13 12:53 UTC (permalink / raw)
To: Jean-Francois Dagenais
Cc: Michael Hennerich, Dmitry Torokhov, dtor, Alexandre Courbot,
linux-gpio@vger.kernel.org, Linux Input
On Mon, Feb 10, 2014 at 6:24 PM, Jean-Francois Dagenais
<jeff.dagenais@gmail.com> wrote:
> which is already found in the common header for adp5588
>
> Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
Patch applied with Michael's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 1/2] gpio: adp5588 - use "unsigned" for the setup and teardown callbacks
2014-02-10 17:24 [PATCH 1/2] gpio: adp5588 - use "unsigned" for the setup and teardown callbacks Jean-Francois Dagenais
2014-02-10 17:24 ` [PATCH 2/2] gpio: adp5588 - add support for gpio names Jean-Francois Dagenais
@ 2014-02-10 20:16 ` Hennerich, Michael
2014-02-13 12:52 ` Linus Walleij
2 siblings, 0 replies; 6+ messages in thread
From: Hennerich, Michael @ 2014-02-10 20:16 UTC (permalink / raw)
To: Jean-Francois Dagenais, dmitry.torokhov@gmail.com, dtor@mail.ru,
linus.walleij@linaro.org, gnurou@gmail.com
Cc: linux-gpio@vger.kernel.org, linux-input@vger.kernel.org
-----Original Message-----
From: Jean-Francois Dagenais [mailto:jeff.dagenais@gmail.com]
Sent: Montag, 10. Februar 2014 18:24
To: Hennerich, Michael; dmitry.torokhov@gmail.com; dtor@mail.ru; linus.walleij@linaro.org; gnurou@gmail.com
Cc: linux-gpio@vger.kernel.org; linux-input@vger.kernel.org; Jean-Francois Dagenais
Subject: [PATCH 1/2] gpio: adp5588 - use "unsigned" for the setup and teardown callbacks
to comply with the rest of the GPIO drivers.
Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
---
include/linux/i2c/adp5588.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/i2c/adp5588.h b/include/linux/i2c/adp5588.h index d8341cb..c215304 100644
--- a/include/linux/i2c/adp5588.h
+++ b/include/linux/i2c/adp5588.h
@@ -161,10 +161,10 @@ struct adp5588_gpio_platform_data {
unsigned irq_base; /* interrupt base # */
unsigned pullup_dis_mask; /* Pull-Up Disable Mask */
int (*setup)(struct i2c_client *client,
- int gpio, unsigned ngpio,
+ unsigned gpio, unsigned ngpio,
void *context);
int (*teardown)(struct i2c_client *client,
- int gpio, unsigned ngpio,
+ unsigned gpio, unsigned ngpio,
void *context);
void *context;
};
--
1.8.5.3
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] gpio: adp5588 - use "unsigned" for the setup and teardown callbacks
2014-02-10 17:24 [PATCH 1/2] gpio: adp5588 - use "unsigned" for the setup and teardown callbacks Jean-Francois Dagenais
2014-02-10 17:24 ` [PATCH 2/2] gpio: adp5588 - add support for gpio names Jean-Francois Dagenais
2014-02-10 20:16 ` [PATCH 1/2] gpio: adp5588 - use "unsigned" for the setup and teardown callbacks Hennerich, Michael
@ 2014-02-13 12:52 ` Linus Walleij
2 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2014-02-13 12:52 UTC (permalink / raw)
To: Jean-Francois Dagenais
Cc: Michael Hennerich, Dmitry Torokhov, dtor, Alexandre Courbot,
linux-gpio@vger.kernel.org, Linux Input
On Mon, Feb 10, 2014 at 6:24 PM, Jean-Francois Dagenais
<jeff.dagenais@gmail.com> wrote:
> to comply with the rest of the GPIO drivers.
>
> Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
Patch applied with Michael's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-13 12:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-10 17:24 [PATCH 1/2] gpio: adp5588 - use "unsigned" for the setup and teardown callbacks Jean-Francois Dagenais
2014-02-10 17:24 ` [PATCH 2/2] gpio: adp5588 - add support for gpio names Jean-Francois Dagenais
2014-02-10 20:17 ` Hennerich, Michael
2014-02-13 12:53 ` Linus Walleij
2014-02-10 20:16 ` [PATCH 1/2] gpio: adp5588 - use "unsigned" for the setup and teardown callbacks Hennerich, Michael
2014-02-13 12:52 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).