* [PATCH] gpio: samsung: Remove double variable assignment
@ 2014-02-15 13:29 Alexander Shiyan
2014-02-24 14:22 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Shiyan @ 2014-02-15 13:29 UTC (permalink / raw)
To: linux-gpio; +Cc: Linus Walleij, Alexandre Courbot, Alexander Shiyan
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
drivers/gpio/gpio-samsung.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
index a85e00b..929f31e 100644
--- a/drivers/gpio/gpio-samsung.c
+++ b/drivers/gpio/gpio-samsung.c
@@ -377,7 +377,6 @@ static int s5p64x0_gpio_setcfg_rbank(struct samsung_gpio_chip *chip,
reg -= 4;
break;
case 6:
- shift = ((off + 1) & 7) * 4;
reg -= 4;
default:
shift = ((off + 1) & 7) * 4;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: samsung: Remove double variable assignment
2014-02-15 13:29 [PATCH] gpio: samsung: Remove double variable assignment Alexander Shiyan
@ 2014-02-24 14:22 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2014-02-24 14:22 UTC (permalink / raw)
To: Alexander Shiyan, Tomasz Figa, Sylwester Nawrocki, Kgene Kim,
Heiko Stübner
Cc: linux-gpio@vger.kernel.org, Alexandre Courbot
On Sat, Feb 15, 2014 at 2:29 PM, Alexander Shiyan <shc_work@mail.ru> wrote:
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> drivers/gpio/gpio-samsung.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
> index a85e00b..929f31e 100644
> --- a/drivers/gpio/gpio-samsung.c
> +++ b/drivers/gpio/gpio-samsung.c
> @@ -377,7 +377,6 @@ static int s5p64x0_gpio_setcfg_rbank(struct samsung_gpio_chip *chip,
> reg -= 4;
> break;
> case 6:
> - shift = ((off + 1) & 7) * 4;
> reg -= 4;
> default:
> shift = ((off + 1) & 7) * 4;
This makes perfect sense from a semantic point of view.
But I'm just worried that it may be a syntactic error after all,
such as a break; missing in case 6?
What does Samsung folks say about this?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-24 14:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-15 13:29 [PATCH] gpio: samsung: Remove double variable assignment Alexander Shiyan
2014-02-24 14:22 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).