linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Chris Zankel <chris@zankel.net>,
	linux-xtensa@linux-xtensa.org, linux-gpio@vger.kernel.org,
	Alexandre Courbot <gnurou@gmail.com>,
	Max Filippov <jcmvbkbc@gmail.com>,
	Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH] gpio: Mark xtensa gpio driver as BROKEN
Date: Mon, 24 Feb 2014 20:05:48 -0800	[thread overview]
Message-ID: <1393301148-5167-1-git-send-email-linux@roeck-us.net> (raw)

xtensa:allmodconfig build fails with

drivers/gpio/gpio-xtensa.c: Assembler messages:
drivers/gpio/gpio-xtensa.c:87: Error: unknown opcode or format name 'read_impwire'
drivers/gpio/gpio-xtensa.c:110: Error: unknown opcode or format name 'rur.expstate'
drivers/gpio/gpio-xtensa.c:124: Error: unknown opcode or format name 'wrmsk_expstate'

Tests with various compiler versions was unsuccessful, suggesting that the
assembler instructions may only be available with some unspecified xtensa
variant. Until that is resolved, mark the driver as broken to enable test
builds.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
I know this is likely controversial, but it seems to be better than letting
builds fail. And maybe it causes a real fix to be submitted.

 drivers/gpio/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 903f24d..0b5a0a1 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -306,6 +306,7 @@ config GPIO_XILINX
 
 config GPIO_XTENSA
 	bool "Xtensa GPIO32 support"
+	depends on BROKEN
 	depends on XTENSA
 	depends on HAVE_XTENSA_GPIO32
 	depends on !SMP
-- 
1.7.9.7


             reply	other threads:[~2014-02-25  4:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-25  4:05 Guenter Roeck [this message]
2014-02-25  4:34 ` [PATCH] gpio: Mark xtensa gpio driver as BROKEN Max Filippov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393301148-5167-1-git-send-email-linux@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=chris@zankel.net \
    --cc=gnurou@gmail.com \
    --cc=jcmvbkbc@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-xtensa@linux-xtensa.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).