* [PATCH] gpio: Mark xtensa gpio driver as BROKEN
@ 2014-02-25 4:05 Guenter Roeck
2014-02-25 4:34 ` Max Filippov
0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2014-02-25 4:05 UTC (permalink / raw)
To: Linus Walleij
Cc: Chris Zankel, linux-xtensa, linux-gpio, Alexandre Courbot,
Max Filippov, Guenter Roeck
xtensa:allmodconfig build fails with
drivers/gpio/gpio-xtensa.c: Assembler messages:
drivers/gpio/gpio-xtensa.c:87: Error: unknown opcode or format name 'read_impwire'
drivers/gpio/gpio-xtensa.c:110: Error: unknown opcode or format name 'rur.expstate'
drivers/gpio/gpio-xtensa.c:124: Error: unknown opcode or format name 'wrmsk_expstate'
Tests with various compiler versions was unsuccessful, suggesting that the
assembler instructions may only be available with some unspecified xtensa
variant. Until that is resolved, mark the driver as broken to enable test
builds.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
I know this is likely controversial, but it seems to be better than letting
builds fail. And maybe it causes a real fix to be submitted.
drivers/gpio/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 903f24d..0b5a0a1 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -306,6 +306,7 @@ config GPIO_XILINX
config GPIO_XTENSA
bool "Xtensa GPIO32 support"
+ depends on BROKEN
depends on XTENSA
depends on HAVE_XTENSA_GPIO32
depends on !SMP
--
1.7.9.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: Mark xtensa gpio driver as BROKEN
2014-02-25 4:05 [PATCH] gpio: Mark xtensa gpio driver as BROKEN Guenter Roeck
@ 2014-02-25 4:34 ` Max Filippov
0 siblings, 0 replies; 2+ messages in thread
From: Max Filippov @ 2014-02-25 4:34 UTC (permalink / raw)
To: Guenter Roeck
Cc: Linus Walleij, Chris Zankel, linux-xtensa@linux-xtensa.org,
linux-gpio, Alexandre Courbot
On Tue, Feb 25, 2014 at 8:05 AM, Guenter Roeck <linux@roeck-us.net> wrote:
> xtensa:allmodconfig build fails with
>
> drivers/gpio/gpio-xtensa.c: Assembler messages:
> drivers/gpio/gpio-xtensa.c:87: Error: unknown opcode or format name 'read_impwire'
> drivers/gpio/gpio-xtensa.c:110: Error: unknown opcode or format name 'rur.expstate'
> drivers/gpio/gpio-xtensa.c:124: Error: unknown opcode or format name 'wrmsk_expstate'
>
> Tests with various compiler versions was unsuccessful, suggesting that the
> assembler instructions may only be available with some unspecified xtensa
> variant. Until that is resolved, mark the driver as broken to enable test
> builds.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> I know this is likely controversial, but it seems to be better than letting
> builds fail. And maybe it causes a real fix to be submitted.
The fix is on the way:
http://lists.linux-xtensa.org/pipermail/linux-xtensa/Week-of-Mon-20140203/001584.html
--
Thanks.
-- Max
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-25 4:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-25 4:05 [PATCH] gpio: Mark xtensa gpio driver as BROKEN Guenter Roeck
2014-02-25 4:34 ` Max Filippov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).