linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] pinctrl: msm: Fix compile error in msm_config_reg()
@ 2014-03-14 15:06 Georgi Djakov
  2014-03-14 15:39 ` Linus Walleij
  0 siblings, 1 reply; 2+ messages in thread
From: Georgi Djakov @ 2014-03-14 15:06 UTC (permalink / raw)
  To: linus.walleij, sboyd, bjorn.andersson
  Cc: linux-gpio, linux-kernel, linux-arm-msm, Georgi Djakov

Fix the following compilation error in msm_config_reg():

drivers/pinctrl/pinctrl-msm.c: In function 'msm_config_reg':
drivers/pinctrl/pinctrl-msm.c:218:4: error: 'reg' undeclared (first use in this
function)

Error is caused by the mix of these two commits:
ed118a5fd951bd2def8249ee251842c4f81fe4bd
051a58b4622f0e1b732acb750097c64bc00ddb93

Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Signed-off-by: Georgi Djakov <gdjakov@mm-sol.com>
---
 drivers/pinctrl/pinctrl-msm.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-msm.c b/drivers/pinctrl/pinctrl-msm.c
index 19d2feb..343f421 100644
--- a/drivers/pinctrl/pinctrl-msm.c
+++ b/drivers/pinctrl/pinctrl-msm.c
@@ -215,7 +215,6 @@ static int msm_config_reg(struct msm_pinctrl *pctrl,
 		*mask = 7;
 		break;
 	case PIN_CONFIG_OUTPUT:
-		*reg = g->ctl_reg;
 		*bit = g->oe_bit;
 		*mask = 1;
 		break;
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] pinctrl: msm: Fix compile error in msm_config_reg()
  2014-03-14 15:06 [PATCH] pinctrl: msm: Fix compile error in msm_config_reg() Georgi Djakov
@ 2014-03-14 15:39 ` Linus Walleij
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2014-03-14 15:39 UTC (permalink / raw)
  To: Georgi Djakov
  Cc: Stephen Boyd, Bjorn Andersson, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org

On Fri, Mar 14, 2014 at 4:06 PM, Georgi Djakov <gdjakov@mm-sol.com> wrote:

> Fix the following compilation error in msm_config_reg():
>
> drivers/pinctrl/pinctrl-msm.c: In function 'msm_config_reg':
> drivers/pinctrl/pinctrl-msm.c:218:4: error: 'reg' undeclared (first use in this
> function)
>
> Error is caused by the mix of these two commits:
> ed118a5fd951bd2def8249ee251842c4f81fe4bd
> 051a58b4622f0e1b732acb750097c64bc00ddb93
>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Signed-off-by: Georgi Djakov <gdjakov@mm-sol.com>

Thanks, but I already sent an identical fix earlier today!

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-03-14 15:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-14 15:06 [PATCH] pinctrl: msm: Fix compile error in msm_config_reg() Georgi Djakov
2014-03-14 15:39 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).