* [PATCH] gpio: Return int for .irq_request_resources callback
@ 2014-03-18 9:40 Axel Lin
2014-03-24 8:56 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2014-03-18 9:40 UTC (permalink / raw)
To: Linus Walleij
Cc: Alexandre Courbot, Jean-Jacques Hiblot, Jamie Iles, linux-gpio
This fixes below build warnings:
CC drivers/gpio/gpio-dwapb.o
drivers/gpio/gpio-dwapb.c: In function 'dwapb_configure_irqs':
drivers/gpio/gpio-dwapb.c:258:33: warning: assignment from incompatible pointer type [enabled by default]
CC drivers/gpio/gpio-pl061.o
drivers/gpio/gpio-pl061.c:261:2: warning: initialization from incompatible pointer type [enabled by default]
drivers/gpio/gpio-pl061.c:261:2: warning: (near initialization for 'pl061_irqchip.irq_request_resources') [enabled by default]
Fixes: 9a63a88cd390 ("gpio: switch drivers to use new callback")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/gpio-dwapb.c | 2 +-
drivers/gpio/gpio-pl061.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
index 2cacb9ed..ed5711f 100644
--- a/drivers/gpio/gpio-dwapb.c
+++ b/drivers/gpio/gpio-dwapb.c
@@ -136,7 +136,7 @@ static void dwapb_irq_disable(struct irq_data *d)
spin_unlock_irqrestore(&bgc->lock, flags);
}
-static unsigned int dwapb_irq_reqres(struct irq_data *d)
+static int dwapb_irq_reqres(struct irq_data *d)
{
struct irq_chip_generic *igc = irq_data_get_irq_chip_data(d);
struct dwapb_gpio *gpio = igc->private;
diff --git a/drivers/gpio/gpio-pl061.c b/drivers/gpio/gpio-pl061.c
index 2189183..d2a0ad5 100644
--- a/drivers/gpio/gpio-pl061.c
+++ b/drivers/gpio/gpio-pl061.c
@@ -233,7 +233,7 @@ static void pl061_irq_unmask(struct irq_data *d)
spin_unlock(&chip->lock);
}
-static unsigned int pl061_irq_reqres(struct irq_data *d)
+static int pl061_irq_reqres(struct irq_data *d)
{
struct pl061_gpio *chip = irq_data_get_irq_chip_data(d);
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: Return int for .irq_request_resources callback
2014-03-18 9:40 [PATCH] gpio: Return int for .irq_request_resources callback Axel Lin
@ 2014-03-24 8:56 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2014-03-24 8:56 UTC (permalink / raw)
To: Axel Lin
Cc: Alexandre Courbot, Jean-Jacques Hiblot, Jamie Iles,
linux-gpio@vger.kernel.org
On Tue, Mar 18, 2014 at 10:40 AM, Axel Lin <axel.lin@ingics.com> wrote:
> This fixes below build warnings:
I already wrote and pushed a similar patch myself, but thanks!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-24 8:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-18 9:40 [PATCH] gpio: Return int for .irq_request_resources callback Axel Lin
2014-03-24 8:56 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).