linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Alan Tull <atull@altera.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Dinh Nguyen <dinguyen@altera.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: [PATCH 2/3] gpio: dwapb: do not create the irq mapping upfront.
Date: Thu, 20 Mar 2014 20:55:23 +0100	[thread overview]
Message-ID: <1395345324-18299-3-git-send-email-bigeasy@linutronix.de> (raw)
In-Reply-To: <1395345324-18299-1-git-send-email-bigeasy@linutronix.de>

After the irq chip got registered the driver creates a mapping for every
gpio line. This mapping be useless if the gpio in question never is
beeing used a irq line. The mapping should be created by the core on
request.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 drivers/gpio/gpio-dwapb.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
index 4d25a06b..0db0b94 100644
--- a/drivers/gpio/gpio-dwapb.c
+++ b/drivers/gpio/gpio-dwapb.c
@@ -211,7 +211,7 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio,
 	struct gpio_chip *gc = &port->bgc.gc;
 	struct device_node *node =  gc->of_node;
 	struct irq_chip_generic	*irq_gc;
-	unsigned int hwirq, ngpio = gc->ngpio;
+	unsigned int ngpio = gc->ngpio;
 	struct irq_chip_type *ct;
 	int err, irq;
 
@@ -263,9 +263,6 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio,
 	irq_set_chained_handler(irq, dwapb_irq_handler);
 	irq_set_handler_data(irq, gpio);
 
-	for (hwirq = 0 ; hwirq < ngpio ; hwirq++)
-		irq_create_mapping(gpio->domain, hwirq);
-
 	port->bgc.gc.to_irq = dwapb_gpio_to_irq;
 }
 
-- 
1.9.1

  parent reply	other threads:[~2014-03-20 19:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-20 19:55 two patches for the synposys gpio controller Sebastian Andrzej Siewior
2014-03-20 19:55 ` [PATCH 1/3] gpio: dwapb: drop irq_setup_generic_chip() Sebastian Andrzej Siewior
2014-03-25 20:37   ` Linus Walleij
2014-03-25 20:37     ` Linus Walleij
2014-03-31 16:22       ` Jamie Iles
2014-03-20 19:55 ` Sebastian Andrzej Siewior [this message]
2014-03-20 20:20   ` [PATCH 2/3] gpio: dwapb: do not create the irq mapping upfront delicious quinoa
2014-03-22 12:37     ` Sebastian Andrzej Siewior
2014-03-25 20:43       ` Linus Walleij
2014-03-25 21:17         ` Sebastian Andrzej Siewior
2014-04-08 13:20           ` Linus Walleij
     [not found] ` <1395345324-18299-1-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2014-03-20 19:55   ` [PATCH 3/3] ARM: dts: socfpga: add gpio pieces Sebastian Andrzej Siewior
2014-03-21 17:24     ` Gerhard Sittig
2014-03-21 19:10       ` Sebastian Andrzej Siewior
2014-03-21 22:06         ` delicious quinoa
2014-03-21 18:14     ` delicious quinoa
2014-03-21 19:08       ` Sebastian Andrzej Siewior
     [not found]       ` <CANk1AXRa4V1ADNaT+T3pYF4zyxni9Y8rmU9UYRoA_7NxW8KWEg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-21 22:15         ` delicious quinoa
2014-03-22 11:28           ` Sebastian Andrzej Siewior
2014-03-26 15:29             ` Dinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395345324-18299-3-git-send-email-bigeasy@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=atull@altera.com \
    --cc=dinguyen@altera.com \
    --cc=gnurou@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).