* [PATCH] gpio: samsung: Add missing "break" statement
@ 2014-03-22 8:35 Alexander Shiyan
2014-03-27 9:11 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Shiyan @ 2014-03-22 8:35 UTC (permalink / raw)
To: linux-gpio; +Cc: Linus Walleij, Alexandre Courbot, Alexander Shiyan
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
drivers/gpio/gpio-samsung.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
index a85e00b..07105ee 100644
--- a/drivers/gpio/gpio-samsung.c
+++ b/drivers/gpio/gpio-samsung.c
@@ -379,6 +379,7 @@ static int s5p64x0_gpio_setcfg_rbank(struct samsung_gpio_chip *chip,
case 6:
shift = ((off + 1) & 7) * 4;
reg -= 4;
+ break;
default:
shift = ((off + 1) & 7) * 4;
break;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: samsung: Add missing "break" statement
2014-03-22 8:35 [PATCH] gpio: samsung: Add missing "break" statement Alexander Shiyan
@ 2014-03-27 9:11 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2014-03-27 9:11 UTC (permalink / raw)
To: Alexander Shiyan, Kukjin Kim, Tomasz Figa, Sylwester Nawrocki
Cc: linux-gpio@vger.kernel.org, Alexandre Courbot
On Sat, Mar 22, 2014 at 9:35 AM, Alexander Shiyan <shc_work@mail.ru> wrote:
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> drivers/gpio/gpio-samsung.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
> index a85e00b..07105ee 100644
> --- a/drivers/gpio/gpio-samsung.c
> +++ b/drivers/gpio/gpio-samsung.c
> @@ -379,6 +379,7 @@ static int s5p64x0_gpio_setcfg_rbank(struct samsung_gpio_chip *chip,
> case 6:
> shift = ((off + 1) & 7) * 4;
> reg -= 4;
> + break;
> default:
> shift = ((off + 1) & 7) * 4;
> break;
Obviously no semantic effect so patch applied as it adds code
readability.
But I'm wondering if default should not be doing reg -= 4; as
well?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-27 9:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-22 8:35 [PATCH] gpio: samsung: Add missing "break" statement Alexander Shiyan
2014-03-27 9:11 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).