* [PATCH] gpio-lynxpoint: force gpio_get() to return "1" and "0" only
@ 2014-03-27 13:02 Mathias Nyman
2014-03-28 20:53 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Mathias Nyman @ 2014-03-27 13:02 UTC (permalink / raw)
To: Linus; +Cc: linux-gpio, linux-kernel, Mathias Nyman
Don't return the IN_LVL_BIT directly, a high gpio line returned
value "1073741824" intestead of "1" because IN_LVL_BIT is BIT(30)
Tested-by: Jerome Blin <jerome.blin@intel.com>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
---
drivers/gpio/gpio-lynxpoint.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-lynxpoint.c b/drivers/gpio/gpio-lynxpoint.c
index 66b1853..803ea3c 100644
--- a/drivers/gpio/gpio-lynxpoint.c
+++ b/drivers/gpio/gpio-lynxpoint.c
@@ -188,7 +188,7 @@ static int lp_irq_type(struct irq_data *d, unsigned type)
static int lp_gpio_get(struct gpio_chip *chip, unsigned offset)
{
unsigned long reg = lp_gpio_reg(chip, offset, LP_CONFIG1);
- return inl(reg) & IN_LVL_BIT;
+ return !!(inl(reg) & IN_LVL_BIT);
}
static void lp_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio-lynxpoint: force gpio_get() to return "1" and "0" only
2014-03-27 13:02 [PATCH] gpio-lynxpoint: force gpio_get() to return "1" and "0" only Mathias Nyman
@ 2014-03-28 20:53 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2014-03-28 20:53 UTC (permalink / raw)
To: Mathias Nyman; +Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
On Thu, Mar 27, 2014 at 2:02 PM, Mathias Nyman
<mathias.nyman@linux.intel.com> wrote:
> Don't return the IN_LVL_BIT directly, a high gpio line returned
> value "1073741824" intestead of "1" because IN_LVL_BIT is BIT(30)
>
> Tested-by: Jerome Blin <jerome.blin@intel.com>
> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-28 20:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-27 13:02 [PATCH] gpio-lynxpoint: force gpio_get() to return "1" and "0" only Mathias Nyman
2014-03-28 20:53 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).