From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: jamie@jamieiles.com
Cc: atull@altera.com, gnurou@gmail.com, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, dinguyen@altera.com,
linus.walleij@linaro.org, sebastian.hesselbarth@gmail.com,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: [PATCH 1/5] gpio: dwapb: drop irq_setup_generic_chip()
Date: Mon, 7 Apr 2014 12:13:05 +0200 [thread overview]
Message-ID: <1396865589-9972-2-git-send-email-bigeasy@linutronix.de> (raw)
In-Reply-To: <1396865589-9972-1-git-send-email-bigeasy@linutronix.de>
The driver calls irq_alloc_domain_generic_chips() which creates a gc and
adds it to gc_list. The driver later then calls irq_setup_generic_chip()
which also initializes the gc and adds it to the gc_list() and this
corrupts the list. Enable LIST_DEBUG and you see the kernel complain.
This isn't required, irq_alloc_domain_generic_chips() did the init.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
drivers/gpio/gpio-dwapb.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
index ed5711f..4d25a06b 100644
--- a/drivers/gpio/gpio-dwapb.c
+++ b/drivers/gpio/gpio-dwapb.c
@@ -260,9 +260,6 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio,
ct->regs.ack = GPIO_PORTA_EOI;
ct->regs.mask = GPIO_INTMASK;
- irq_setup_generic_chip(irq_gc, IRQ_MSK(port->bgc.gc.ngpio),
- IRQ_GC_INIT_NESTED_LOCK, IRQ_NOREQUEST, 0);
-
irq_set_chained_handler(irq, dwapb_irq_handler);
irq_set_handler_data(irq, gpio);
--
1.9.1
next prev parent reply other threads:[~2014-04-07 10:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 10:13 patches for the synopsys gpio controller, rount 3 Sebastian Andrzej Siewior
2014-04-07 10:13 ` Sebastian Andrzej Siewior [this message]
2014-04-08 19:57 ` [PATCH 1/5] gpio: dwapb: drop irq_setup_generic_chip() delicious quinoa
2014-04-10 17:35 ` Linus Walleij
2014-04-07 10:13 ` [PATCH 2/5] gpio: dwapb: use irq_linear_revmap() for the faster lookup Sebastian Andrzej Siewior
2014-04-07 10:13 ` [PATCH 3/5] gpio: dwapb: use irq_gc_lock() for locking instead bc's lock Sebastian Andrzej Siewior
2014-04-07 10:13 ` [PATCH 4/5] gpio: dwapb: use a second irq chip Sebastian Andrzej Siewior
2014-04-07 10:13 ` [PATCH 5/5] gpio: dwapb: use d->mask instead od BIT(bit) Sebastian Andrzej Siewior
2014-04-07 12:26 ` Gerhard Sittig
2014-04-07 18:26 ` Sebastian Andrzej Siewior
2014-04-07 19:01 ` Gerhard Sittig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396865589-9972-2-git-send-email-bigeasy@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=atull@altera.com \
--cc=dinguyen@altera.com \
--cc=gnurou@gmail.com \
--cc=jamie@jamieiles.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).