From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: jamie@jamieiles.com
Cc: atull@altera.com, gnurou@gmail.com, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, dinguyen@altera.com,
linus.walleij@linaro.org, sebastian.hesselbarth@gmail.com,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: [PATCH 4/5] gpio: dwapb: use a second irq chip
Date: Mon, 7 Apr 2014 12:13:08 +0200 [thread overview]
Message-ID: <1396865589-9972-5-git-send-email-bigeasy@linutronix.de> (raw)
In-Reply-To: <1396865589-9972-1-git-send-email-bigeasy@linutronix.de>
Right new have one irq chip running always in level mode. It would nicer
to have two irq chips where one is handling level type interrupts and
the other one is doing edge interrupts. So we can have at runtime two users
where one is using edge and the other level.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
drivers/gpio/gpio-dwapb.c | 21 +++++++++++++++++++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
index 752ccb1..13f1ad0 100644
--- a/drivers/gpio/gpio-dwapb.c
+++ b/drivers/gpio/gpio-dwapb.c
@@ -192,6 +192,8 @@ static int dwapb_irq_set_type(struct irq_data *d, u32 type)
break;
}
+ irq_setup_alt_chip(d, type);
+
writel(level, gpio->regs + GPIO_INTTYPE_LEVEL);
writel(polarity, gpio->regs + GPIO_INT_POLARITY);
irq_gc_unlock(igc);
@@ -221,7 +223,7 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio,
if (!gpio->domain)
return;
- err = irq_alloc_domain_generic_chips(gpio->domain, ngpio, 1,
+ err = irq_alloc_domain_generic_chips(gpio->domain, ngpio, 2,
"gpio-dwapb", handle_level_irq,
IRQ_NOREQUEST, 0,
IRQ_GC_INIT_NESTED_LOCK);
@@ -242,7 +244,20 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio,
irq_gc->reg_base = gpio->regs;
irq_gc->private = gpio;
- ct = irq_gc->chip_types;
+ ct = &irq_gc->chip_types[0];
+ ct->chip.irq_ack = irq_gc_ack_set_bit;
+ ct->chip.irq_mask = irq_gc_mask_set_bit;
+ ct->chip.irq_unmask = irq_gc_mask_clr_bit;
+ ct->chip.irq_set_type = dwapb_irq_set_type;
+ ct->chip.irq_enable = dwapb_irq_enable;
+ ct->chip.irq_disable = dwapb_irq_disable;
+ ct->chip.irq_request_resources = dwapb_irq_reqres;
+ ct->chip.irq_release_resources = dwapb_irq_relres;
+ ct->regs.ack = GPIO_PORTA_EOI;
+ ct->regs.mask = GPIO_INTMASK;
+ ct->type = IRQ_TYPE_LEVEL_MASK;
+
+ ct = &irq_gc->chip_types[1];
ct->chip.irq_ack = irq_gc_ack_set_bit;
ct->chip.irq_mask = irq_gc_mask_set_bit;
ct->chip.irq_unmask = irq_gc_mask_clr_bit;
@@ -253,6 +268,8 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio,
ct->chip.irq_release_resources = dwapb_irq_relres;
ct->regs.ack = GPIO_PORTA_EOI;
ct->regs.mask = GPIO_INTMASK;
+ ct->type = IRQ_TYPE_EDGE_BOTH;
+ ct->handler = handle_edge_irq;
irq_set_chained_handler(irq, dwapb_irq_handler);
irq_set_handler_data(irq, gpio);
--
1.9.1
next prev parent reply other threads:[~2014-04-07 10:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 10:13 patches for the synopsys gpio controller, rount 3 Sebastian Andrzej Siewior
2014-04-07 10:13 ` [PATCH 1/5] gpio: dwapb: drop irq_setup_generic_chip() Sebastian Andrzej Siewior
2014-04-08 19:57 ` delicious quinoa
2014-04-10 17:35 ` Linus Walleij
2014-04-07 10:13 ` [PATCH 2/5] gpio: dwapb: use irq_linear_revmap() for the faster lookup Sebastian Andrzej Siewior
2014-04-07 10:13 ` [PATCH 3/5] gpio: dwapb: use irq_gc_lock() for locking instead bc's lock Sebastian Andrzej Siewior
2014-04-07 10:13 ` Sebastian Andrzej Siewior [this message]
2014-04-07 10:13 ` [PATCH 5/5] gpio: dwapb: use d->mask instead od BIT(bit) Sebastian Andrzej Siewior
2014-04-07 12:26 ` Gerhard Sittig
2014-04-07 18:26 ` Sebastian Andrzej Siewior
2014-04-07 19:01 ` Gerhard Sittig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396865589-9972-5-git-send-email-bigeasy@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=atull@altera.com \
--cc=dinguyen@altera.com \
--cc=gnurou@gmail.com \
--cc=jamie@jamieiles.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).