From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: jamie@jamieiles.com
Cc: atull@altera.com, gnurou@gmail.com, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, dinguyen@altera.com,
linus.walleij@linaro.org, sebastian.hesselbarth@gmail.com,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: [PATCH 5/5] gpio: dwapb: use d->mask instead od BIT(bit)
Date: Mon, 7 Apr 2014 12:13:09 +0200 [thread overview]
Message-ID: <1396865589-9972-6-git-send-email-bigeasy@linutronix.de> (raw)
In-Reply-To: <1396865589-9972-1-git-send-email-bigeasy@linutronix.de>
d->mask contains exact the same information as BIT(bit) so we could save
a few cycles here.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
drivers/gpio/gpio-dwapb.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
index 13f1ad0..d85fc2e 100644
--- a/drivers/gpio/gpio-dwapb.c
+++ b/drivers/gpio/gpio-dwapb.c
@@ -113,7 +113,7 @@ static void dwapb_irq_enable(struct irq_data *d)
irq_gc_lock(igc);
val = readl(gpio->regs + GPIO_INTEN);
- val |= BIT(d->hwirq);
+ val |= d->mask;
writel(val, gpio->regs + GPIO_INTEN);
irq_gc_unlock(igc);
}
@@ -126,7 +126,7 @@ static void dwapb_irq_disable(struct irq_data *d)
irq_gc_lock(igc);
val = readl(gpio->regs + GPIO_INTEN);
- val &= ~BIT(d->hwirq);
+ val &= ~d->mask;
writel(val, gpio->regs + GPIO_INTEN);
irq_gc_unlock(igc);
}
@@ -158,7 +158,7 @@ static int dwapb_irq_set_type(struct irq_data *d, u32 type)
{
struct irq_chip_generic *igc = irq_data_get_irq_chip_data(d);
struct dwapb_gpio *gpio = igc->private;
- int bit = d->hwirq;
+ u32 mask = d->mask;
unsigned long level, polarity;
if (type & ~(IRQ_TYPE_EDGE_RISING | IRQ_TYPE_EDGE_FALLING |
@@ -171,24 +171,24 @@ static int dwapb_irq_set_type(struct irq_data *d, u32 type)
switch (type) {
case IRQ_TYPE_EDGE_BOTH:
- level |= BIT(bit);
- dwapb_toggle_trigger(gpio, bit);
+ level |= mask;
+ dwapb_toggle_trigger(gpio, d->hwirq);
break;
case IRQ_TYPE_EDGE_RISING:
- level |= BIT(bit);
- polarity |= BIT(bit);
+ level |= mask;
+ polarity |= mask;
break;
case IRQ_TYPE_EDGE_FALLING:
- level |= BIT(bit);
- polarity &= ~BIT(bit);
+ level |= mask;
+ polarity &= ~mask;
break;
case IRQ_TYPE_LEVEL_HIGH:
- level &= ~BIT(bit);
- polarity |= BIT(bit);
+ level &= ~mask;
+ polarity |= mask;
break;
case IRQ_TYPE_LEVEL_LOW:
- level &= ~BIT(bit);
- polarity &= ~BIT(bit);
+ level &= ~mask;
+ polarity &= ~mask;
break;
}
--
1.9.1
next prev parent reply other threads:[~2014-04-07 10:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 10:13 patches for the synopsys gpio controller, rount 3 Sebastian Andrzej Siewior
2014-04-07 10:13 ` [PATCH 1/5] gpio: dwapb: drop irq_setup_generic_chip() Sebastian Andrzej Siewior
2014-04-08 19:57 ` delicious quinoa
2014-04-10 17:35 ` Linus Walleij
2014-04-07 10:13 ` [PATCH 2/5] gpio: dwapb: use irq_linear_revmap() for the faster lookup Sebastian Andrzej Siewior
2014-04-07 10:13 ` [PATCH 3/5] gpio: dwapb: use irq_gc_lock() for locking instead bc's lock Sebastian Andrzej Siewior
2014-04-07 10:13 ` [PATCH 4/5] gpio: dwapb: use a second irq chip Sebastian Andrzej Siewior
2014-04-07 10:13 ` Sebastian Andrzej Siewior [this message]
2014-04-07 12:26 ` [PATCH 5/5] gpio: dwapb: use d->mask instead od BIT(bit) Gerhard Sittig
2014-04-07 18:26 ` Sebastian Andrzej Siewior
2014-04-07 19:01 ` Gerhard Sittig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396865589-9972-6-git-send-email-bigeasy@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=atull@altera.com \
--cc=dinguyen@altera.com \
--cc=gnurou@gmail.com \
--cc=jamie@jamieiles.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).