linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <acourbot@nvidia.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Santosh Shilimkar <santosh.shilimkar@ti.com>,
	Kevin Hilman <khilman@linaro.org>,
	linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Subject: [RFC PATCH 2/5] gpiolib: set gpio_chip operations on add using a gpio_chip_ops
Date: Tue,  8 Apr 2014 20:20:12 +0200	[thread overview]
Message-ID: <1396981215-24888-3-git-send-email-javier.martinez@collabora.co.uk> (raw)
In-Reply-To: <1396981215-24888-1-git-send-email-javier.martinez@collabora.co.uk>

This is a transitional change to avoid breaking git bisect-ability
while converting GPIO controller drivers to set their operations by
using the newly introduced struct gpio_chip_ops virtual function table.

It should be removed once all GPIO chip drivers have been converted.

Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---
 drivers/gpio/gpiolib.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 761013f..f0cc93a 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1188,6 +1188,25 @@ int gpiochip_add(struct gpio_chip *chip)
 		goto fail;
 	}
 
+	/*
+	 * REVISIT: this is a workaround to not break git bisectability by
+	 * allowing GPIO controller drivers to set either either the function
+	 * pointers embedded in struct gpio_chip or by using a gpio_chip_ops.
+	 *
+	 * Should be removed once all drivers are converted to set chip->ops.
+	 */
+	if (chip->ops) {
+		chip->request          = chip->ops->request;
+		chip->free             = chip->ops->free;
+		chip->get_direction    = chip->ops->get_direction;
+		chip->direction_input  = chip->ops->direction_input;
+		chip->direction_output = chip->ops->direction_output;
+		chip->get              = chip->ops->get;
+		chip->set              = chip->ops->set;
+		chip->set_debounce     = chip->ops->set_debounce;
+		chip->dbg_show         = chip->ops->dbg_show;
+	}
+
 	spin_lock_irqsave(&gpio_lock, flags);
 
 	if (base < 0) {
-- 
1.9.0

  parent reply	other threads:[~2014-04-08 18:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-08 18:20 [RFC PATCH 0/5] add gpio_chip_ops to hold GPIO operations Javier Martinez Canillas
2014-04-08 18:20 ` [RFC PATCH 1/5] gpio: add a vtable to abstract GPIO controller operations Javier Martinez Canillas
2014-04-08 18:20 ` Javier Martinez Canillas [this message]
2014-04-08 18:20 ` [RFC PATCH 3/5] gpio: omap: convert driver to use gpio_chip_ops Javier Martinez Canillas
2014-04-08 18:20 ` [RFC PATCH 4/5] gpio: twl4030: " Javier Martinez Canillas
2014-04-08 18:20 ` [RFC PATCH 5/5] gpio: switch to use struct struct gpio_chip_ops Javier Martinez Canillas
2014-04-10  7:36 ` [RFC PATCH 0/5] add gpio_chip_ops to hold GPIO operations Alexandre Courbot
2014-04-10  9:34   ` Javier Martinez Canillas
2014-04-10 11:00     ` Andy Shevchenko
2014-04-10 11:46       ` Javier Martinez Canillas
2014-04-22 11:36 ` Linus Walleij
2014-04-22 12:28   ` Javier Martinez Canillas
2014-04-22 14:17     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1396981215-24888-3-git-send-email-javier.martinez@collabora.co.uk \
    --to=javier.martinez@collabora.co.uk \
    --cc=acourbot@nvidia.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=khilman@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).