From: Eric Paris <eparis@redhat.com>
To: Vincent Donnefort <vdonnefort@gmail.com>
Cc: linux-kernel@vger.kernel.org, ptyser@xes-inc.com,
linus.walleij@linaro.org, gnurou@gmail.com,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH] gpio: ich: set regs and reglen for i3100 and ich6 chipset
Date: Tue, 15 Apr 2014 10:43:52 -0400 [thread overview]
Message-ID: <1397573032.2471.0.camel@flatline.rdu.redhat.com> (raw)
In-Reply-To: <1397564503-5175-1-git-send-email-vincent.donnefort@seagate.com>
On Tue, 2014-04-15 at 14:21 +0200, Vincent Donnefort wrote:
> From: Vincent Donnefort <vdonnefort@gmail.com>
>
> This patch fixes kernel NULL pointer BUG introduced by the following commit:
> b667cf488aa9476b0ab64acd91f2a96f188cfd21
> gpio: ich: Add support for multiple register addresses.
>
> Signed-off-by: Vincent Donnefort <vdonnefort@gmail.com>
Things seem much happier now! Thank you sir!
Tested-by: Eric Paris <eparis@redhat.com>
>
> diff --git a/drivers/gpio/gpio-ich.c b/drivers/gpio/gpio-ich.c
> index e73c675..7030422 100644
> --- a/drivers/gpio/gpio-ich.c
> +++ b/drivers/gpio/gpio-ich.c
> @@ -305,6 +305,8 @@ static struct ichx_desc ich6_desc = {
>
> .ngpio = 50,
> .have_blink = true,
> + .regs = ichx_regs,
> + .reglen = ichx_reglen,
> };
>
> /* Intel 3100 */
> @@ -324,6 +326,8 @@ static struct ichx_desc i3100_desc = {
> .uses_gpe0 = true,
>
> .ngpio = 50,
> + .regs = ichx_regs,
> + .reglen = ichx_reglen,
> };
>
> /* ICH7 and ICH8-based */
next prev parent reply other threads:[~2014-04-15 14:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 17:55 [git bisect regression 3.15-rc1] NULL ptr deref in ichx_gpio_probe Eric Paris
2014-04-14 19:26 ` Eric Paris
2014-04-15 8:40 ` Vincent Donnefort
2014-04-15 12:21 ` [PATCH] gpio: ich: set regs and reglen for i3100 and ich6 chipset Vincent Donnefort
2014-04-15 14:43 ` Eric Paris [this message]
2014-04-22 21:15 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397573032.2471.0.camel@flatline.rdu.redhat.com \
--to=eparis@redhat.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ptyser@xes-inc.com \
--cc=vdonnefort@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).