* [PATCH] gpiolib: of: remove gpio_to_desc() usage
@ 2014-04-22 12:43 Linus Walleij
2014-04-23 1:54 ` Alexandre Courbot
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2014-04-22 12:43 UTC (permalink / raw)
To: linux-gpio; +Cc: Alexandre Courbot, Linus Walleij
As demonstrated by commit
390d82e312c56b75407a3606cbcde8c4bc7f10ae
"gpiolib: ACPI: remove gpio_to_desc() usage"
gpio_to_desc() must die. Replace one of its usage by the
newly-introduced gpiochip_get_desc() function.
Cc: Alexandre Courbot <acourbot@nvidia.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/gpio/gpiolib-of.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
index 2024d45e5503..db98d3a12f70 100644
--- a/drivers/gpio/gpiolib-of.c
+++ b/drivers/gpio/gpiolib-of.c
@@ -48,7 +48,7 @@ static int of_gpiochip_find_and_xlate(struct gpio_chip *gc, void *data)
if (ret < 0)
return false;
- gg_data->out_gpio = gpio_to_desc(ret + gc->base);
+ gg_data->out_gpio = gpiochip_get_desc(gc, ret);
return true;
}
--
1.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpiolib: of: remove gpio_to_desc() usage
2014-04-22 12:43 [PATCH] gpiolib: of: remove gpio_to_desc() usage Linus Walleij
@ 2014-04-23 1:54 ` Alexandre Courbot
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Courbot @ 2014-04-23 1:54 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-gpio@vger.kernel.org, Alexandre Courbot
On Tue, Apr 22, 2014 at 9:43 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> As demonstrated by commit
> 390d82e312c56b75407a3606cbcde8c4bc7f10ae
> "gpiolib: ACPI: remove gpio_to_desc() usage"
>
> gpio_to_desc() must die. Replace one of its usage by the
> newly-introduced gpiochip_get_desc() function.
Yay, let that thing die.
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-23 1:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-22 12:43 [PATCH] gpiolib: of: remove gpio_to_desc() usage Linus Walleij
2014-04-23 1:54 ` Alexandre Courbot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).