Linux GPIO subsystem development
 help / color / mirror / Atom feed
From: Basavaraj Natikar <bnatikar@amd.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	silverducks@altlinux.org,
	Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
	Mario Limonciello <mario.limonciello@amd.com>
Cc: linux-gpio@vger.kernel.org, Mika Westerberg <westeri@kernel.org>,
	Linus Walleij <linusw@kernel.org>,
	Bartosz Golaszewski <brgl@kernel.org>,
	linux-acpi@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] gpiolib: acpi: Add ignore_wake quirk for Gigabyte B650 GAMING X AX
Date: Fri, 20 Nov 2026 12:14:44 +0530	[thread overview]
Message-ID: <139a1c14-39a1-4bc5-aba3-673ba603821d@amd.com> (raw)
In-Reply-To: <av8EszUWsJIq3hIV@ashevche-desk.local>

+Cc: Mario


On 11/19/2026 7:46 PM, Andy Shevchenko wrote:
> On Thu, Nov 19, 2026 at 03:28:45PM +0300, silverducks@altlinux.org wrote:
>
> +Cc: AMD folks.
>
>> The firmware's _AEI table on the Gigabyte B650 GAMING X AX declares AMD
>> GPIO pin 3 as GpioInt(Edge, ActiveLow, ExclusiveAndWake).

Please share the decoded _AEI so we can confirm the pin and
controller and point to the GpioInt(... ExclusiveAndWake) entry,
pin_table[0] == 3 on AMDI0030 (i.e. "AMDI0030:00@3" is correct).

>> gpiolib-acpi
>> requests it as "ACPI:Event" and amd_gpio_irq_set_wake() arms the hardware
>> S3 wake bit for that pin. The firmware then sends the signal a few seconds
>> after entering S3, so the machine resumes on it's own six to ten seconds
>> after suspend.
>>
>> Pin 3 is the only wake signal the OS can see for the whole GPP7 PCIe
>> domain, and GPP7 has no _PRW, so ignoring this wake flag is the only way to

You say GPP7 has no _PRW. Can you confirm none of the GPP7 child
devices expose power/wakeup, and that disabling wake there
(echo disabled > /sys/.../power/wakeup) does NOT stop the spurious
wake? If a per-device wake control exists, that's preferable to a DMI
quirk.

>> keep S3 reliable on this board. Wake from USB keyboards/mouse and
>> Wake-on-LAN through that domain is lost as a consequence, but I figure S3
>> not working at all is worse. The power button still wakes the machine as
>> normal.
> Hmm... And you are running the latest BIOS?

+1. If a newer BIOS de-flags the pin (ExclusiveAndWake -> Exclusive) or
stops asserting it in S3, this quirk would permanently disable GPP7 wake
on units that no longer need it. Please confirm the BIOS version it
reproduces on and whether the latest available BIOS still shows it.

>> ---
>> v2 - Put real name in signoff; Moved testing information to comment.
>>
>> Quirk tested on upstream kernel v7.4-rc2.  Also tested on stable kernel
>> v6.12, which is the version where the issue was originally diagnosed.
> ...
>
>> +	{
>> +		/*
>> +		 * Spurious wake from S3: the firmware _AEI table declares AMD GPIO
>> +		 * pin 3 (GPP7 group) as Edge/ActiveLow ExclusiveAndWake, so gpiolib-acpi
>> +		 * requests it as ACPI:Event and amd_gpio_irq_set_wake() arms the
>> +		 * hardware S0i3/S3 wake bit. The firmware asserts this signal during

Wording nit: this is a desktop board, so it only suspends to S3.
amd_gpio_irq_set_wake() sets the S0i3/S3/S4 wake bits together, but S0i3
does not apply here and your commit message already says just "S3 wake
bit". Please make the comment match and drop S0i3.

Thanks,
--
Basavaraj

>> +		 * S3 entry regardless of the PCI wake sources configured by the OS,
>> +		 * waking the machine a few seconds after suspend.
>> +		 */
>> +		.matches = {
>> +			DMI_MATCH(DMI_SYS_VENDOR, "Gigabyte Technology Co., Ltd."),
>> +			DMI_MATCH(DMI_PRODUCT_NAME, "B650 GAMING X AX"),
>> +		},
>> +		.driver_data = &(struct acpi_gpiolib_dmi_quirk) {
>> +			.ignore_wake = "AMDI0030:00@3",
>> +		},
>> +	},


  reply	other threads:[~2026-11-20  6:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  8:38 [PATCH] gpiolib: acpi: Add ignore_wake quirk for Gigabyte B650 GAMING X AX silverducks
2026-11-19 11:45 ` Andy Shevchenko
2026-11-19 12:28 ` [PATCH v2] " silverducks
2026-11-19 14:16   ` Andy Shevchenko
2026-11-20  6:44     ` Basavaraj Natikar [this message]
2026-11-20 12:58       ` silverducks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=139a1c14-39a1-4bc5-aba3-673ba603821d@amd.com \
    --to=bnatikar@amd.com \
    --cc=Basavaraj.Natikar@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=brgl@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=silverducks@altlinux.org \
    --cc=stable@vger.kernel.org \
    --cc=westeri@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox