From: George Cherian <george.cherian@ti.com>
To: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Cc: gnurou@gmail.com, linus.walleij@linaro.org,
kuninori.morimoto.gx@renesas.com,
George Cherian <george.cherian@ti.com>
Subject: [PATCH 2/2] gpio: pcf857x: Add IRQF_SHARED when request irq
Date: Fri, 23 May 2014 11:27:27 +0530 [thread overview]
Message-ID: <1400824647-2525-2-git-send-email-george.cherian@ti.com> (raw)
In-Reply-To: <1400824647-2525-1-git-send-email-george.cherian@ti.com>
It's quite possible that multiple pcf857x can be hooked up
to the same interrupt line with the processor. So add IRQF_SHARED
in request irq..
Signed-off-by: George Cherian <george.cherian@ti.com>
---
drivers/gpio/gpio-pcf857x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-pcf857x.c b/drivers/gpio/gpio-pcf857x.c
index 5acffed..27b4675 100644
--- a/drivers/gpio/gpio-pcf857x.c
+++ b/drivers/gpio/gpio-pcf857x.c
@@ -262,7 +262,7 @@ static int pcf857x_irq_domain_init(struct pcf857x *gpio,
/* enable real irq */
status = devm_request_threaded_irq(&client->dev, client->irq,
NULL, pcf857x_irq, IRQF_ONESHOT |
- IRQF_TRIGGER_FALLING,
+ IRQF_TRIGGER_FALLING | IRQF_SHARED,
dev_name(&client->dev), gpio);
if (status)
--
1.8.3.1
next prev parent reply other threads:[~2014-05-23 5:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 5:57 [PATCH 1/2] gpio: pcf857x: Avoid calling irq_domain_cleanup twice George Cherian
2014-05-23 5:57 ` George Cherian [this message]
2014-05-28 7:21 ` [PATCH 2/2] gpio: pcf857x: Add IRQF_SHARED when request irq Linus Walleij
2014-05-23 6:10 ` [PATCH 1/2] gpio: pcf857x: Avoid calling irq_domain_cleanup twice Alexandre Courbot
2014-05-28 7:20 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400824647-2525-2-git-send-email-george.cherian@ti.com \
--to=george.cherian@ti.com \
--cc=gnurou@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).