From: Andrew Ruder <andrew.ruder@elecsyscorp.com>
To: linux-gpio@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, gnurou@gmail.com,
linus.walleij@linaro.org,
Andrew Ruder <andrew.ruder@elecsyscorp.com>
Subject: [PATCH] gpio-pxa: gpio0 and gpio1 support on dt
Date: Thu, 5 Jun 2014 14:13:23 -0500 [thread overview]
Message-ID: <1401995603-25997-1-git-send-email-andrew.ruder@elecsyscorp.com> (raw)
pxa_gpio_probe() has some issues supporting the gpio0 and gpio1
interrupts under device-tree - it never actually sets up the chain
handler to get interrupts on edge detect for GPIO0 and GPIO1.
Signed-off-by: Andrew Ruder <andrew.ruder@elecsyscorp.com>
---
drivers/gpio/gpio-pxa.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index 42e6e64..19f1a95 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -649,6 +649,11 @@ static int pxa_gpio_probe(struct platform_device *pdev)
handle_edge_irq);
set_irq_flags(irq, IRQF_VALID | IRQF_PROBE);
}
+ } else {
+ if (irq0 > 0)
+ irq_set_chained_handler(irq0, pxa_gpio_demux_handler);
+ if (irq1 > 0)
+ irq_set_chained_handler(irq1, pxa_gpio_demux_handler);
}
irq_set_chained_handler(irq_mux, pxa_gpio_demux_handler);
--
1.9.0.rc3.12.gbc97e2d
next reply other threads:[~2014-06-05 19:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 19:13 Andrew Ruder [this message]
2014-06-12 8:43 ` [PATCH] gpio-pxa: gpio0 and gpio1 support on dt Linus Walleij
2014-06-17 0:18 ` Haojian Zhuang
2014-07-07 10:55 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401995603-25997-1-git-send-email-andrew.ruder@elecsyscorp.com \
--to=andrew.ruder@elecsyscorp.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).