* [PATCH] gpio: rcar: clamp returned value to [0,1]
@ 2014-06-24 2:19 Jürg Billeter
2014-07-07 15:27 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Jürg Billeter @ 2014-06-24 2:19 UTC (permalink / raw)
To: Linus Walleij, Alexandre Courbot
Cc: Magnus Damm, linux-gpio, linux-kernel, Jürg Billeter
While it will be clamped to bool by gpiolib, let's make this sane
in the driver as well.
Signed-off-by: Jürg Billeter <j@bitron.ch>
---
drivers/gpio/gpio-rcar.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
index 0c9f803..7c62121 100644
--- a/drivers/gpio/gpio-rcar.c
+++ b/drivers/gpio/gpio-rcar.c
@@ -240,9 +240,9 @@ static int gpio_rcar_get(struct gpio_chip *chip, unsigned offset)
/* testing on r8a7790 shows that INDT does not show correct pin state
* when configured as output, so use OUTDT in case of output pins */
if (gpio_rcar_read(gpio_to_priv(chip), INOUTSEL) & bit)
- return (int)(gpio_rcar_read(gpio_to_priv(chip), OUTDT) & bit);
+ return !!(gpio_rcar_read(gpio_to_priv(chip), OUTDT) & bit);
else
- return (int)(gpio_rcar_read(gpio_to_priv(chip), INDT) & bit);
+ return !!(gpio_rcar_read(gpio_to_priv(chip), INDT) & bit);
}
static void gpio_rcar_set(struct gpio_chip *chip, unsigned offset, int value)
--
2.0.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: rcar: clamp returned value to [0,1]
2014-06-24 2:19 [PATCH] gpio: rcar: clamp returned value to [0,1] Jürg Billeter
@ 2014-07-07 15:27 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2014-07-07 15:27 UTC (permalink / raw)
To: Jürg Billeter
Cc: Alexandre Courbot, Magnus Damm, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
On Tue, Jun 24, 2014 at 4:19 AM, Jürg Billeter <j@bitron.ch> wrote:
> While it will be clamped to bool by gpiolib, let's make this sane
> in the driver as well.
>
> Signed-off-by: Jürg Billeter <j@bitron.ch>
Patch obviously correct to applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-07 15:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-24 2:19 [PATCH] gpio: rcar: clamp returned value to [0,1] Jürg Billeter
2014-07-07 15:27 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).