From: Javier Martinez Canillas <javier@dowhile0.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <acourbot@nvidia.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Kevin Hilman <khilman@linaro.org>,
Tony Lindgren <tony@atomide.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>, Nishanth Menon <nm@ti.com>,
linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org,
Javier Martinez Canillas <jmartinez@softcrates.net>
Subject: [PATCH 1/3] gpio: omap: Remove unnecessary lockdep class
Date: Fri, 27 Jun 2014 22:17:35 +0200 [thread overview]
Message-ID: <1403900258-20717-2-git-send-email-jmartinez@softcrates.net> (raw)
In-Reply-To: <1403900258-20717-1-git-send-email-jmartinez@softcrates.net>
GPIO irqchips assign to the cascaded IRQs their own lock class
in order to avoid warnings about lockdep recursions since that
allow the lockdep core to keep track of things.
Since commit e45d1c80 ("gpio: put GPIO IRQs into their own lock class")
there is no need to do this in a driver if it's using the GPIO
irqchip helpers since gpiolib already assigns a lockdep class.
Signed-off-by: Javier Martinez Canillas <jmartinez@softcrates.net>
---
drivers/gpio/gpio-omap.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index 00f29aa..4b4e1b4 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -1025,11 +1025,6 @@ static void __init omap_gpio_show_rev(struct gpio_bank *bank)
called = true;
}
-/* This lock class tells lockdep that GPIO irqs are in a different
- * category than their parents, so it won't report false recursion.
- */
-static struct lock_class_key gpio_lock_class;
-
static void omap_gpio_mod_init(struct gpio_bank *bank)
{
void __iomem *base = bank->base;
@@ -1152,7 +1147,6 @@ static int omap_gpio_chip_init(struct gpio_bank *bank)
for (j = 0; j < bank->width; j++) {
int irq = irq_find_mapping(bank->chip.irqdomain, j);
- irq_set_lockdep_class(irq, &gpio_lock_class);
if (bank->is_mpuio) {
omap_mpuio_alloc_gc(bank, irq, bank->width);
irq_set_chip_and_handler(irq, NULL, NULL);
--
2.0.0.rc2
next prev parent reply other threads:[~2014-06-27 20:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 20:17 [PATCH 0/3] GPIO OMAP driver changes for v3.17 Javier Martinez Canillas
2014-06-27 20:17 ` Javier Martinez Canillas [this message]
2014-07-08 7:54 ` [PATCH 1/3] gpio: omap: Remove unnecessary lockdep class Linus Walleij
2014-06-27 20:17 ` [PATCH 2/3] gpio: omap: Remove unneeded include Javier Martinez Canillas
2014-07-08 7:55 ` Linus Walleij
2014-06-27 20:17 ` [PATCH 3/3] gpio: omap: Add an omap prefix to all functions Javier Martinez Canillas
2014-07-08 7:57 ` Linus Walleij
2014-07-02 20:55 ` [PATCH 0/3] GPIO OMAP driver changes for v3.17 Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403900258-20717-2-git-send-email-jmartinez@softcrates.net \
--to=javier@dowhile0.org \
--cc=aaro.koskinen@iki.fi \
--cc=acourbot@nvidia.com \
--cc=jmartinez@softcrates.net \
--cc=khilman@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).