From: Linus Walleij <linus.walleij@linaro.org>
To: linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Simon Baatz <gmbnomis@gmail.com>
Subject: [PATCH] mmc: slot-gpio: restore error reporting
Date: Mon, 18 Aug 2014 22:28:00 -0500 [thread overview]
Message-ID: <1408418880-10250-1-git-send-email-linus.walleij@linaro.org> (raw)
The patch switching the MMC core to use GPIO descriptors
depromoted errors to debug messages for unsuccessful attempt
to get CD or WP GPIOs. This was because sometimes these are
not specified, and that should not be an error.
However that is not so helpful: explicitly check whether a
GPIO is not specified (i.e. -ENOENT is returned) and if there
is some other error, report it with dev_err().
Reported-by: Simon Baatz <gmbnomis@gmail.com>
Cc: Simon Baatz <gmbnomis@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/mmc/core/host.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
index 048c6d687cc9..6f7ed9c50346 100644
--- a/drivers/mmc/core/host.c
+++ b/drivers/mmc/core/host.c
@@ -368,9 +368,11 @@ int mmc_of_parse(struct mmc_host *host)
if (ret) {
if (ret == -EPROBE_DEFER)
return ret;
- dev_dbg(host->parent,
- "Failed to request CD GPIO: %d\n",
- ret);
+ if (ret != -ENOENT) {
+ dev_err(host->parent,
+ "Failed to request CD GPIO: %d\n",
+ ret);
+ }
} else
dev_info(host->parent, "Got CD GPIO\n");
}
@@ -383,9 +385,11 @@ int mmc_of_parse(struct mmc_host *host)
if (ret) {
if (ret == -EPROBE_DEFER)
goto out;
- dev_dbg(host->parent,
- "Failed to request WP GPIO: %d\n",
- ret);
+ if (ret != -ENOENT) {
+ dev_err(host->parent,
+ "Failed to request WP GPIO: %d\n",
+ ret);
+ }
} else
dev_info(host->parent, "Got WP GPIO\n");
--
1.9.3
next reply other threads:[~2014-08-19 3:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 3:28 Linus Walleij [this message]
2014-08-19 7:29 ` [PATCH] mmc: slot-gpio: restore error reporting Ulf Hansson
2014-08-19 18:32 ` Simon Baatz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408418880-10250-1-git-send-email-linus.walleij@linaro.org \
--to=linus.walleij@linaro.org \
--cc=cjb@laptop.org \
--cc=gmbnomis@gmail.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).