From: Alexandre Courbot <acourbot@nvidia.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
gnurou@gmail.com, Alexandre Courbot <acourbot@nvidia.com>
Subject: [PATCH v2 0/2] gpio: acpi: some sanity fixes
Date: Tue, 19 Aug 2014 10:06:07 -0700 [thread overview]
Message-ID: <1408467969-21226-1-git-send-email-acourbot@nvidia.com> (raw)
These two small patches perform some sanity changes in gpiolib-acpi:
1) Stop assuming there is a direct 1:1 mapping between GPIO descriptors
and GPIO numbers. This should not be taken for granted and will likely
change in the future. GPIO descriptors should be handled like regulators
and other allocated resources, i.e. obtained and preserved for later use
instead of constantly requested using gpiochip_get_desc()
2) Change the prototype of gpiochip_request_own_desc() to match other
functions in driver.h. This results is a simplification of the related
code in gpiolib-acpi, which should be a good thing.
Changes since v1:
- Fixed a misdeclaration of struct gpio_desc
- Added Mika's Tested-by
Alexandre Courbot (2):
gpio: acpi: normalize use of gpiochip_get_desc()
gpio: change gpiochip_request_own_desc() prototype
Documentation/gpio/driver.txt | 3 ++-
drivers/gpio/gpiolib-acpi.c | 30 +++++++++++-------------------
drivers/gpio/gpiolib.c | 18 ++++++++++++++----
include/linux/gpio/driver.h | 3 ++-
4 files changed, 29 insertions(+), 25 deletions(-)
--
2.0.4
next reply other threads:[~2014-08-19 17:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 17:06 Alexandre Courbot [this message]
2014-08-19 17:06 ` [PATCH v2 1/2] gpio: acpi: normalize use of gpiochip_get_desc() Alexandre Courbot
2014-08-29 6:57 ` Linus Walleij
2014-08-19 17:06 ` [PATCH v2 2/2] gpio: change gpiochip_request_own_desc() prototype Alexandre Courbot
2014-08-29 6:57 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408467969-21226-1-git-send-email-acourbot@nvidia.com \
--to=acourbot@nvidia.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).