From: Soren Brinkmann <soren.brinkmann@xilinx.com>
To: Alexandre Courbot <gnurou@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: "Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"Michal Simek" <michal.simek@xilinx.com>,
"Harini Katakam" <harinik@xilinx.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Ezra Savard" <ezras@xilinx.com>
Subject: [PATCH 0/3] gpio: zynq: Fix suspend/wake
Date: Fri, 29 Aug 2014 10:58:44 -0700 [thread overview]
Message-ID: <1409335127-26712-1-git-send-email-soren.brinkmann@xilinx.com> (raw)
Hi Linus,
after our discussion during the push of the gpio-zynq driver, we took a
closer look at the LED and gpio_keys drivers.
For LEDs and other simple use-cases where you need to control an output,
that driver is great and a patch to get the LEDs on our boards added to
DT is pending.
For the keys, and especially wake, things didn't look that good. Testing
revealed a couple of flaws in the driver's wake-related implementation
which should be fixed with this series.
I'm still not fully convinced that the gpio_keys are the best
replacement for the sysfs interface when it comes to inputs. For that
reason and to have a way to do some quick wake testing, I'd like to
propose adding the ability to control wake through the sysfs interface
(patch 3).
The series is based on Linus T's current tip + the Zynq-related patches
from gpio/for-next + Lars' pending patch 'gpio: zynq: Take bank
offset into account when reporting a IRQ'.
A branch with all those patches can be found here:
https://github.com/sorenb-xlnx/linux-xlnx/commits/gpio
Thanks,
Sören
Ezra Savard (2):
gpio: zynq: Mask non-wakeup GPIO interrupts on suspend
gpio: zynq: Fixed broken wakeup implementation
Soren Brinkmann (1):
gpio: lib-sysfs: Add 'wakeup' attribute
drivers/gpio/gpio-zynq.c | 38 +++++++++++++---------
drivers/gpio/gpiolib-sysfs.c | 75 ++++++++++++++++++++++++++++++++++++++++----
2 files changed, 92 insertions(+), 21 deletions(-)
--
2.1.0.1.g27b9230
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2014-08-29 17:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 17:58 Soren Brinkmann [this message]
2014-08-29 17:58 ` [PATCH 1/3] gpio: zynq: Mask non-wakeup GPIO interrupts on suspend Soren Brinkmann
2014-09-04 16:22 ` Linus Walleij
2014-08-29 17:58 ` [PATCH 2/3] gpio: zynq: Fixed broken wakeup implementation Soren Brinkmann
2014-09-04 16:27 ` Linus Walleij
2014-09-04 16:45 ` Sören Brinkmann
2014-08-29 17:58 ` [PATCH 3/3] gpio: lib-sysfs: Add 'wakeup' attribute Soren Brinkmann
2014-09-04 16:29 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409335127-26712-1-git-send-email-soren.brinkmann@xilinx.com \
--to=soren.brinkmann@xilinx.com \
--cc=ezras@xilinx.com \
--cc=gnurou@gmail.com \
--cc=harinik@xilinx.com \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).