linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Cohen <david.a.cohen@linux.intel.com>
To: linus.walleij@linaro.org
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	David Cohen <david.a.cohen@linux.intel.com>,
	stable@vger.kernel.org
Subject: [PATCH] pinctrl: baytrail: show output gpio state correctly on Intel Baytrail
Date: Mon, 13 Oct 2014 11:23:59 -0700	[thread overview]
Message-ID: <1413224639-21552-1-git-send-email-david.a.cohen@linux.intel.com> (raw)
In-Reply-To: <1412355319-18946-1-git-send-email-david.a.cohen@linux.intel.com>

Even if a gpio pin is set to output, we still need to set INPUT_EN bit
to be able to read its value. Without this change, we'll always read low
level state.

Cc: <stable@vger.kernel.org> # v3.14+
Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
---

Hi,

I'm resending same v1 patch but now copying linux stable and linux gpio.
This patch is meant for all linux stable trees >= v3.14.

Br, David
---

 drivers/pinctrl/pinctrl-baytrail.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-baytrail.c b/drivers/pinctrl/pinctrl-baytrail.c
index e12e5b07f6d7..c23d8ded936d 100644
--- a/drivers/pinctrl/pinctrl-baytrail.c
+++ b/drivers/pinctrl/pinctrl-baytrail.c
@@ -318,7 +318,7 @@ static int byt_gpio_direction_output(struct gpio_chip *chip,
 		"Potential Error: Setting GPIO with direct_irq_en to output");
 
 	reg_val = readl(reg) | BYT_DIR_MASK;
-	reg_val &= ~BYT_OUTPUT_EN;
+	reg_val &= ~(BYT_OUTPUT_EN | BYT_INPUT_EN);
 
 	if (value)
 		writel(reg_val | BYT_LEVEL, reg);
-- 
2.1.0

       reply	other threads:[~2014-10-13 18:23 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1412355319-18946-1-git-send-email-david.a.cohen@linux.intel.com>
2014-10-13 18:23 ` David Cohen [this message]
2014-10-13 19:14   ` [PATCH] pinctrl: baytrail: show output gpio state correctly on Intel Baytrail Felipe Balbi
2014-10-13 19:24     ` David Cohen
2014-10-13 19:26       ` Felipe Balbi
2014-10-13 19:36         ` Felipe Balbi
2014-10-13 20:19           ` David Cohen
2014-10-28 10:15           ` Linus Walleij
2014-10-28 14:42             ` Felipe Balbi
2014-10-31  8:12               ` Linus Walleij
2014-10-31 13:20                 ` Felipe Balbi
2014-10-31 16:23                   ` David Cohen
2014-10-31 18:45                     ` David Cohen
2014-11-03  9:24                       ` Mika Westerberg
2014-11-03 15:00                         ` Felipe Balbi
2014-11-03 15:27                           ` Mika Westerberg
2014-11-03 15:35                             ` Felipe Balbi
2014-11-03 15:42                             ` Mika Westerberg
2014-11-03 15:50                               ` Felipe Balbi
2014-11-03 18:42                                 ` Mika Westerberg
2014-11-03 20:40                                   ` Felipe Balbi
2014-11-04  7:51                                     ` Mika Westerberg
2014-11-04 14:44                                       ` Felipe Balbi
2014-11-03 22:19                                   ` David Cohen
2014-11-04  7:59                                     ` Mika Westerberg
2014-11-04 18:05                                       ` David Cohen
2014-11-04 18:57                                         ` Mika Westerberg
2014-11-04 19:11                                           ` David Cohen
2014-11-04 19:34                                             ` Mika Westerberg
2014-11-04 21:51                                               ` David Cohen
2014-11-05  8:40                                                 ` Mika Westerberg
2014-11-14  9:40                                                 ` Linus Walleij
2014-11-14  9:39                                           ` Linus Walleij
2014-11-14  9:53                                             ` Mika Westerberg
2014-11-14 23:19                                               ` Rafael J. Wysocki
2014-11-14  9:30                                   ` Linus Walleij
2014-11-03 15:33                   ` Linus Walleij
2014-10-13 20:16         ` David Cohen
2014-10-14 17:54   ` [PATCH v2] " David Cohen
2014-10-14 18:19     ` Felipe Balbi
2014-10-28 10:17     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1413224639-21552-1-git-send-email-david.a.cohen@linux.intel.com \
    --to=david.a.cohen@linux.intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).