From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Cohen Subject: [PATCH v2] pinctrl: baytrail: show output gpio state correctly on Intel Baytrail Date: Tue, 14 Oct 2014 10:54:37 -0700 Message-ID: <1413309277-32485-1-git-send-email-david.a.cohen@linux.intel.com> References: <1413224639-21552-1-git-send-email-david.a.cohen@linux.intel.com> Return-path: Received: from mga02.intel.com ([134.134.136.20]:20966 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752580AbaJNRyH (ORCPT ); Tue, 14 Oct 2014 13:54:07 -0400 In-Reply-To: <1413224639-21552-1-git-send-email-david.a.cohen@linux.intel.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: linus.walleij@linaro.org Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, balbi@ti.com, David Cohen , stable@vger.kernel.org, Mathias Nyman Even if a gpio pin is set to output, we still need to set INPUT_EN functionality (by clearing INPUT_EN bit) to be able to read the pin's level. E.g. without this change, we'll always read low level state from sysfs. Cc: # v3.14+ Cc: Mathias Nyman Signed-off-by: David Cohen --- v1 to v2: improved patch's body description as requested by Felipe Balbi --- drivers/pinctrl/pinctrl-baytrail.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-baytrail.c b/drivers/pinctrl/pinctrl-baytrail.c index e12e5b07f6d7..c23d8ded936d 100644 --- a/drivers/pinctrl/pinctrl-baytrail.c +++ b/drivers/pinctrl/pinctrl-baytrail.c @@ -318,7 +318,7 @@ static int byt_gpio_direction_output(struct gpio_chip *chip, "Potential Error: Setting GPIO with direct_irq_en to output"); reg_val = readl(reg) | BYT_DIR_MASK; - reg_val &= ~BYT_OUTPUT_EN; + reg_val &= ~(BYT_OUTPUT_EN | BYT_INPUT_EN); if (value) writel(reg_val | BYT_LEVEL, reg); -- 2.1.0