* [PATCH] gpio: msm-v1: Fix typo in function argument
@ 2014-10-24 14:29 Daniel Thompson
2014-10-27 5:00 ` Alexandre Courbot
2014-10-30 15:00 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Daniel Thompson @ 2014-10-24 14:29 UTC (permalink / raw)
To: Jiri Kosina
Cc: Daniel Thompson, linux-gpio, linux-kernel, patches, linaro-kernel,
John Stultz, Sumit Semwal, Linus Walleij, Alexandre Courbot
irq_set_irq_wake() treats its second argument as a boolean. It is much
easier to read code when constant booleans are either 0 or 1!
This particular line of code distracted me somewhat when I was doing a bit of
work in a code browser since it (spuriously) got me worried that I had
misunderstood how irq_set_irq_wake() worked.
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>
---
drivers/gpio/gpio-msm-v1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-msm-v1.c b/drivers/gpio/gpio-msm-v1.c
index 73b7396..997e61e 100644
--- a/drivers/gpio/gpio-msm-v1.c
+++ b/drivers/gpio/gpio-msm-v1.c
@@ -686,7 +686,7 @@ static int gpio_msm_v1_probe(struct platform_device *pdev)
irq_set_chained_handler(irq1, msm_gpio_irq_handler);
irq_set_chained_handler(irq2, msm_gpio_irq_handler);
irq_set_irq_wake(irq1, 1);
- irq_set_irq_wake(irq2, 2);
+ irq_set_irq_wake(irq2, 1);
return 0;
}
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: msm-v1: Fix typo in function argument
2014-10-24 14:29 [PATCH] gpio: msm-v1: Fix typo in function argument Daniel Thompson
@ 2014-10-27 5:00 ` Alexandre Courbot
2014-10-30 15:00 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Courbot @ 2014-10-27 5:00 UTC (permalink / raw)
To: Daniel Thompson
Cc: Jiri Kosina, linux-gpio@vger.kernel.org,
Linux Kernel Mailing List, patches, linaro-kernel, John Stultz,
Sumit Semwal, Linus Walleij
On Fri, Oct 24, 2014 at 11:29 PM, Daniel Thompson
<daniel.thompson@linaro.org> wrote:
> irq_set_irq_wake() treats its second argument as a boolean. It is much
> easier to read code when constant booleans are either 0 or 1!
>
> This particular line of code distracted me somewhat when I was doing a bit of
> work in a code browser since it (spuriously) got me worried that I had
> misunderstood how irq_set_irq_wake() worked.
>
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> ---
> drivers/gpio/gpio-msm-v1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-msm-v1.c b/drivers/gpio/gpio-msm-v1.c
> index 73b7396..997e61e 100644
> --- a/drivers/gpio/gpio-msm-v1.c
> +++ b/drivers/gpio/gpio-msm-v1.c
> @@ -686,7 +686,7 @@ static int gpio_msm_v1_probe(struct platform_device *pdev)
> irq_set_chained_handler(irq1, msm_gpio_irq_handler);
> irq_set_chained_handler(irq2, msm_gpio_irq_handler);
> irq_set_irq_wake(irq1, 1);
> - irq_set_irq_wake(irq2, 2);
> + irq_set_irq_wake(irq2, 1);
> return 0;
That could be confusing indeed.
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: msm-v1: Fix typo in function argument
2014-10-24 14:29 [PATCH] gpio: msm-v1: Fix typo in function argument Daniel Thompson
2014-10-27 5:00 ` Alexandre Courbot
@ 2014-10-30 15:00 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2014-10-30 15:00 UTC (permalink / raw)
To: Daniel Thompson
Cc: Jiri Kosina, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, Patch Tracking, linaro-kernel,
John Stultz, Sumit Semwal, Alexandre Courbot
On Fri, Oct 24, 2014 at 4:29 PM, Daniel Thompson
<daniel.thompson@linaro.org> wrote:
> irq_set_irq_wake() treats its second argument as a boolean. It is much
> easier to read code when constant booleans are either 0 or 1!
>
> This particular line of code distracted me somewhat when I was doing a bit of
> work in a code browser since it (spuriously) got me worried that I had
> misunderstood how irq_set_irq_wake() worked.
>
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Alexandre Courbot <gnurou@gmail.com>
Patch applied with Alexandre's Review tag.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-30 15:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-24 14:29 [PATCH] gpio: msm-v1: Fix typo in function argument Daniel Thompson
2014-10-27 5:00 ` Alexandre Courbot
2014-10-30 15:00 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).