* [PATCH 1/1] gpio: mcp23s08: Do not free unrequested interrupt
@ 2014-11-11 8:08 Alexander Stein
2014-11-14 10:07 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Stein @ 2014-11-11 8:08 UTC (permalink / raw)
To: Linus Walleij, Alexandre Courbot; +Cc: Alexander Stein, linux-gpio
If devm_request_threaded_irq fails for some reason we call
mcp23s08_irq_teardown afterwards.
Do not free the unrequested interrupt in this case. free_irq can also be
omitted for the error free case because we use devm_request_threaded_irq.
Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
---
drivers/gpio/gpio-mcp23s08.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpio-mcp23s08.c b/drivers/gpio/gpio-mcp23s08.c
index 8488e2f..d5e9586 100644
--- a/drivers/gpio/gpio-mcp23s08.c
+++ b/drivers/gpio/gpio-mcp23s08.c
@@ -514,8 +514,6 @@ static void mcp23s08_irq_teardown(struct mcp23s08 *mcp)
{
unsigned int irq, i;
- free_irq(mcp->irq, mcp);
-
for (i = 0; i < mcp->chip.ngpio; i++) {
irq = irq_find_mapping(mcp->irq_domain, i);
if (irq > 0)
--
2.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] gpio: mcp23s08: Do not free unrequested interrupt
2014-11-11 8:08 [PATCH 1/1] gpio: mcp23s08: Do not free unrequested interrupt Alexander Stein
@ 2014-11-14 10:07 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2014-11-14 10:07 UTC (permalink / raw)
To: Alexander Stein; +Cc: Alexandre Courbot, linux-gpio@vger.kernel.org
On Tue, Nov 11, 2014 at 9:08 AM, Alexander Stein
<alexander.stein@systec-electronic.com> wrote:
> If devm_request_threaded_irq fails for some reason we call
> mcp23s08_irq_teardown afterwards.
> Do not free the unrequested interrupt in this case. free_irq can also be
> omitted for the error free case because we use devm_request_threaded_irq.
>
> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
Patch applied.
We don't have a maintainer for this driver... I'd like someone to look into
converting it to use GPIOLIB_IRQCHIP.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-14 10:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-11 8:08 [PATCH 1/1] gpio: mcp23s08: Do not free unrequested interrupt Alexander Stein
2014-11-14 10:07 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).