* [PATCH] gpio: sx150x: Fix comparing wrong value with chip->irq_masked
@ 2014-12-16 6:22 Axel Lin
2014-12-17 2:27 ` Alexandre Courbot
2015-01-13 9:23 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2014-12-16 6:22 UTC (permalink / raw)
To: Linus Walleij, Alexandre Courbot; +Cc: linux-gpio, Gregory Bean
Fix a copy-paste bug.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/gpio-sx150x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-sx150x.c b/drivers/gpio/gpio-sx150x.c
index bce6c61..6e37257 100644
--- a/drivers/gpio/gpio-sx150x.c
+++ b/drivers/gpio/gpio-sx150x.c
@@ -401,7 +401,7 @@ static void sx150x_irq_bus_sync_unlock(struct irq_data *d)
/* Avoid updates if nothing changed */
if (chip->dev_sense == chip->irq_sense &&
- chip->dev_sense == chip->irq_masked)
+ chip->dev_masked == chip->irq_masked)
goto out;
chip->dev_sense = chip->irq_sense;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: sx150x: Fix comparing wrong value with chip->irq_masked
2014-12-16 6:22 [PATCH] gpio: sx150x: Fix comparing wrong value with chip->irq_masked Axel Lin
@ 2014-12-17 2:27 ` Alexandre Courbot
2015-01-13 9:23 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Courbot @ 2014-12-17 2:27 UTC (permalink / raw)
To: Axel Lin; +Cc: Linus Walleij, linux-gpio@vger.kernel.org, Gregory Bean
On Tue, Dec 16, 2014 at 3:22 PM, Axel Lin <axel.lin@ingics.com> wrote:
> Fix a copy-paste bug.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: sx150x: Fix comparing wrong value with chip->irq_masked
2014-12-16 6:22 [PATCH] gpio: sx150x: Fix comparing wrong value with chip->irq_masked Axel Lin
2014-12-17 2:27 ` Alexandre Courbot
@ 2015-01-13 9:23 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2015-01-13 9:23 UTC (permalink / raw)
To: Axel Lin; +Cc: Alexandre Courbot, linux-gpio@vger.kernel.org, Gregory Bean
On Tue, Dec 16, 2014 at 7:22 AM, Axel Lin <axel.lin@ingics.com> wrote:
> Fix a copy-paste bug.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Patch applied with Alex's review tag.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-13 9:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-16 6:22 [PATCH] gpio: sx150x: Fix comparing wrong value with chip->irq_masked Axel Lin
2014-12-17 2:27 ` Alexandre Courbot
2015-01-13 9:23 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).