Re: [PATCH v3 2/4] pinctrl: samsung: add dedicated SoC eint suspend/resume callbacks

["André Draszik" <andre.draszik@linaro.org>]

On Thu, 2025-03-06 at 20:42 +0000, Peter Griffin wrote:
> gs101 needs it's own suspend/resume callbacks to use the newly
> added eint_fltcon_offset for saving & restoring fltcon0 & fltcon1
> registers. It also differs to previous SoCs in that fltcon1
> register doesn't always exist for each bank.
> 
> exynosautov920 also has dedicated logic for using eint_con_offset
> and eint_mask_offset for saving & restoring it's registers.
> 
> Refactor the existing platform specific suspend/resume callback
> so that each SoC variant has their own callback containing the
> SoC specific logic.
> 
> Additionally we now call drvdata->suspend() & drvdata->resume()
> from within the loop that iterates the banks in
> samsung_pinctrl_suspend() and samsung_pinctrl_resume().
> 
> This simplifies the logic, and allows us to remove the
> clk_enable() and clk_disable() from the callbacks.
> 
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> Changes since v2:
> * Remove useless init (Andre)
> * make it clear set_wakeup is conditional on bank->eint_type (Andre)
> 
> Changes since v1:
> * Split code refactor & gs101 parts into separate patches (Andre)
> ---
>  drivers/pinctrl/samsung/pinctrl-exynos-arm64.c |  28 ++--
>  drivers/pinctrl/samsung/pinctrl-exynos.c       | 201 ++++++++++---------------
>  drivers/pinctrl/samsung/pinctrl-exynos.h       |   6 +-
>  drivers/pinctrl/samsung/pinctrl-samsung.c      |  11 +-
>  drivers/pinctrl/samsung/pinctrl-samsung.h      |   8 +-
>  5 files changed, 109 insertions(+), 145 deletions(-)

Reviewed-by: André Draszik <andre.draszik@linaro.org>