* [PATCH 1/3] gpu: drm: tilcdc: don't use devm_pinctrl_get_select_default() in probe
@ 2014-12-22 22:16 Wolfram Sang
2014-12-22 22:16 ` [PATCH 2/3] mmc: host: " Wolfram Sang
2014-12-22 22:16 ` [PATCH 3/3] net: ieee802154: " Wolfram Sang
0 siblings, 2 replies; 6+ messages in thread
From: Wolfram Sang @ 2014-12-22 22:16 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-gpio, Wolfram Sang, David Airlie, dri-devel
Since commit ab78029ecc34 (drivers/pinctrl: grab default handles from device
core), we can rely on device core for setting the default pins.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/gpu/drm/tilcdc/tilcdc_panel.c | 7 -------
drivers/gpu/drm/tilcdc/tilcdc_slave.c | 7 -------
drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 7 -------
3 files changed, 21 deletions(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
index 7a0315855e90..5aec25d273f4 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
@@ -15,8 +15,6 @@
* this program. If not, see <http://www.gnu.org/licenses/>.
*/
-#include <linux/pinctrl/pinmux.h>
-#include <linux/pinctrl/consumer.h>
#include <linux/backlight.h>
#include <linux/gpio/consumer.h>
#include <video/display_timing.h>
@@ -351,7 +349,6 @@ static int panel_probe(struct platform_device *pdev)
struct device_node *bl_node, *node = pdev->dev.of_node;
struct panel_module *panel_mod;
struct tilcdc_module *mod;
- struct pinctrl *pinctrl;
int ret;
/* bail out early if no DT data: */
@@ -399,10 +396,6 @@ static int panel_probe(struct platform_device *pdev)
tilcdc_module_init(mod, "panel", &panel_module_ops);
- pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
- if (IS_ERR(pinctrl))
- dev_warn(&pdev->dev, "pins are not configured\n");
-
panel_mod->timings = of_get_display_timings(node);
if (!panel_mod->timings) {
dev_err(&pdev->dev, "could not get panel timings\n");
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_slave.c b/drivers/gpu/drm/tilcdc/tilcdc_slave.c
index 3775fd49dac4..67cae0846365 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_slave.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_slave.c
@@ -16,8 +16,6 @@
*/
#include <linux/i2c.h>
-#include <linux/pinctrl/pinmux.h>
-#include <linux/pinctrl/consumer.h>
#include <drm/drm_encoder_slave.h>
#include "tilcdc_drv.h"
@@ -312,7 +310,6 @@ static int slave_probe(struct platform_device *pdev)
struct device_node *i2c_node;
struct slave_module *slave_mod;
struct tilcdc_module *mod;
- struct pinctrl *pinctrl;
uint32_t i2c_phandle;
struct i2c_adapter *slavei2c;
int ret = -EINVAL;
@@ -361,10 +358,6 @@ static int slave_probe(struct platform_device *pdev)
tilcdc_module_init(mod, "slave", &slave_module_ops);
- pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
- if (IS_ERR(pinctrl))
- dev_warn(&pdev->dev, "pins are not configured\n");
-
tilcdc_slave_probedefer(false);
return 0;
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
index 354c47ca6374..205f46135da4 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
@@ -18,8 +18,6 @@
#include <linux/i2c.h>
#include <linux/gpio.h>
#include <linux/of_gpio.h>
-#include <linux/pinctrl/pinmux.h>
-#include <linux/pinctrl/consumer.h>
#include "tilcdc_drv.h"
@@ -312,7 +310,6 @@ static int tfp410_probe(struct platform_device *pdev)
struct device_node *i2c_node;
struct tfp410_module *tfp410_mod;
struct tilcdc_module *mod;
- struct pinctrl *pinctrl;
uint32_t i2c_phandle;
int ret = -EINVAL;
@@ -331,10 +328,6 @@ static int tfp410_probe(struct platform_device *pdev)
tilcdc_module_init(mod, "tfp410", &tfp410_module_ops);
- pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
- if (IS_ERR(pinctrl))
- dev_warn(&pdev->dev, "pins are not configured\n");
-
if (of_property_read_u32(node, "i2c", &i2c_phandle)) {
dev_err(&pdev->dev, "could not get i2c bus phandle\n");
goto fail;
--
2.1.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] mmc: host: don't use devm_pinctrl_get_select_default() in probe
2014-12-22 22:16 [PATCH 1/3] gpu: drm: tilcdc: don't use devm_pinctrl_get_select_default() in probe Wolfram Sang
@ 2014-12-22 22:16 ` Wolfram Sang
2014-12-23 15:37 ` Ulf Hansson
2014-12-22 22:16 ` [PATCH 3/3] net: ieee802154: " Wolfram Sang
1 sibling, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2014-12-22 22:16 UTC (permalink / raw)
To: linux-kernel
Cc: linux-gpio, Wolfram Sang, Nicolas Pitre, Chris Ball, Ulf Hansson,
linux-mmc
Since commit ab78029ecc34 (drivers/pinctrl: grab default handles from device
core), we can rely on device core for setting the default pins.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/mmc/host/mvsdio.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c
index 4f8618f4522d..a2cb92851f1f 100644
--- a/drivers/mmc/host/mvsdio.c
+++ b/drivers/mmc/host/mvsdio.c
@@ -25,7 +25,6 @@
#include <linux/of_irq.h>
#include <linux/mmc/host.h>
#include <linux/mmc/slot-gpio.h>
-#include <linux/pinctrl/consumer.h>
#include <asm/sizes.h>
#include <asm/unaligned.h>
@@ -704,7 +703,6 @@ static int mvsd_probe(struct platform_device *pdev)
const struct mbus_dram_target_info *dram;
struct resource *r;
int ret, irq;
- struct pinctrl *pinctrl;
r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
irq = platform_get_irq(pdev, 0);
@@ -721,10 +719,6 @@ static int mvsd_probe(struct platform_device *pdev)
host->mmc = mmc;
host->dev = &pdev->dev;
- pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
- if (IS_ERR(pinctrl))
- dev_warn(&pdev->dev, "no pins associated\n");
-
/*
* Some non-DT platforms do not pass a clock, and the clock
* frequency is passed through platform_data. On DT platforms,
--
2.1.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] net: ieee802154: don't use devm_pinctrl_get_select_default() in probe
2014-12-22 22:16 [PATCH 1/3] gpu: drm: tilcdc: don't use devm_pinctrl_get_select_default() in probe Wolfram Sang
2014-12-22 22:16 ` [PATCH 2/3] mmc: host: " Wolfram Sang
@ 2014-12-22 22:16 ` Wolfram Sang
[not found] ` <CAEUmHyYbPbeWzHEaPYFAV+wTGYqhz7pps6XEzNrK_jQm_HPKpg@mail.gmail.com>
2014-12-30 6:17 ` Marcel Holtmann
1 sibling, 2 replies; 6+ messages in thread
From: Wolfram Sang @ 2014-12-22 22:16 UTC (permalink / raw)
To: linux-kernel
Cc: linux-gpio, Wolfram Sang, Varka Bhadram, Alexander Aring,
linux-wpan, netdev
Since commit ab78029ecc34 (drivers/pinctrl: grab default handles from device
core), we can rely on device core for setting the default pins.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/net/ieee802154/cc2520.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
index c2b7da3da183..033473448d9f 100644
--- a/drivers/net/ieee802154/cc2520.c
+++ b/drivers/net/ieee802154/cc2520.c
@@ -19,7 +19,6 @@
#include <linux/workqueue.h>
#include <linux/interrupt.h>
#include <linux/skbuff.h>
-#include <linux/pinctrl/consumer.h>
#include <linux/of_gpio.h>
#include <linux/ieee802154.h>
@@ -841,7 +840,6 @@ done:
static int cc2520_probe(struct spi_device *spi)
{
struct cc2520_private *priv;
- struct pinctrl *pinctrl;
struct cc2520_platform_data *pdata;
int ret;
@@ -854,11 +852,6 @@ static int cc2520_probe(struct spi_device *spi)
spi_set_drvdata(spi, priv);
- pinctrl = devm_pinctrl_get_select_default(&spi->dev);
- if (IS_ERR(pinctrl))
- dev_warn(&spi->dev,
- "pinctrl pins are not configured\n");
-
pdata = cc2520_get_platform_data(spi);
if (!pdata) {
dev_err(&spi->dev, "no platform data\n");
--
2.1.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] net: ieee802154: don't use devm_pinctrl_get_select_default() in probe
[not found] ` <CAEUmHyYbPbeWzHEaPYFAV+wTGYqhz7pps6XEzNrK_jQm_HPKpg@mail.gmail.com>
@ 2014-12-23 0:28 ` Varka Bhadram
0 siblings, 0 replies; 6+ messages in thread
From: Varka Bhadram @ 2014-12-23 0:28 UTC (permalink / raw)
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-wpan - ML, netdev@vger.kernel.org
Thanks for the patch.
Acked-by: Varka Bhadram <varkabhadram@gmail.com>
On Tue, Dec 23, 2014 at 5:40 AM, Varka Bhadram <varkabhadram@gmail.com> wrote:
>
> Thanks for the patch.
>
> Acked-by: Varka Bhadram <varkabhadram@gmail.com>
>
> On Tue, Dec 23, 2014 at 3:46 AM, Wolfram Sang <wsa@the-dreams.de> wrote:
>>
>> Since commit ab78029ecc34 (drivers/pinctrl: grab default handles from device
>> core), we can rely on device core for setting the default pins.
>>
>> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
>> ---
>> drivers/net/ieee802154/cc2520.c | 7 -------
>> 1 file changed, 7 deletions(-)
>>
>> diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
>> index c2b7da3da183..033473448d9f 100644
>> --- a/drivers/net/ieee802154/cc2520.c
>> +++ b/drivers/net/ieee802154/cc2520.c
>> @@ -19,7 +19,6 @@
>> #include <linux/workqueue.h>
>> #include <linux/interrupt.h>
>> #include <linux/skbuff.h>
>> -#include <linux/pinctrl/consumer.h>
>> #include <linux/of_gpio.h>
>> #include <linux/ieee802154.h>
>>
>> @@ -841,7 +840,6 @@ done:
>> static int cc2520_probe(struct spi_device *spi)
>> {
>> struct cc2520_private *priv;
>> - struct pinctrl *pinctrl;
>> struct cc2520_platform_data *pdata;
>> int ret;
>>
>> @@ -854,11 +852,6 @@ static int cc2520_probe(struct spi_device *spi)
>>
>> spi_set_drvdata(spi, priv);
>>
>> - pinctrl = devm_pinctrl_get_select_default(&spi->dev);
>> - if (IS_ERR(pinctrl))
>> - dev_warn(&spi->dev,
>> - "pinctrl pins are not configured\n");
>> -
>> pdata = cc2520_get_platform_data(spi);
>> if (!pdata) {
>> dev_err(&spi->dev, "no platform data\n");
>> --
>> 2.1.3
>>
>
>
>
> --
> Thanks and Regards,
> Varka Bhadram.
--
Thanks and Regards,
Varka Bhadram.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] mmc: host: don't use devm_pinctrl_get_select_default() in probe
2014-12-22 22:16 ` [PATCH 2/3] mmc: host: " Wolfram Sang
@ 2014-12-23 15:37 ` Ulf Hansson
0 siblings, 0 replies; 6+ messages in thread
From: Ulf Hansson @ 2014-12-23 15:37 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Nicolas Pitre, Chris Ball, linux-mmc
On 22 December 2014 at 23:16, Wolfram Sang <wsa@the-dreams.de> wrote:
> Since commit ab78029ecc34 (drivers/pinctrl: grab default handles from device
> core), we can rely on device core for setting the default pins.
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Thanks! Applied for next, with an updated prefix of the commit header
to "mmc: mvsdio:".
Kind regards
Uffe
> ---
> drivers/mmc/host/mvsdio.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c
> index 4f8618f4522d..a2cb92851f1f 100644
> --- a/drivers/mmc/host/mvsdio.c
> +++ b/drivers/mmc/host/mvsdio.c
> @@ -25,7 +25,6 @@
> #include <linux/of_irq.h>
> #include <linux/mmc/host.h>
> #include <linux/mmc/slot-gpio.h>
> -#include <linux/pinctrl/consumer.h>
>
> #include <asm/sizes.h>
> #include <asm/unaligned.h>
> @@ -704,7 +703,6 @@ static int mvsd_probe(struct platform_device *pdev)
> const struct mbus_dram_target_info *dram;
> struct resource *r;
> int ret, irq;
> - struct pinctrl *pinctrl;
>
> r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> irq = platform_get_irq(pdev, 0);
> @@ -721,10 +719,6 @@ static int mvsd_probe(struct platform_device *pdev)
> host->mmc = mmc;
> host->dev = &pdev->dev;
>
> - pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> - if (IS_ERR(pinctrl))
> - dev_warn(&pdev->dev, "no pins associated\n");
> -
> /*
> * Some non-DT platforms do not pass a clock, and the clock
> * frequency is passed through platform_data. On DT platforms,
> --
> 2.1.3
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] net: ieee802154: don't use devm_pinctrl_get_select_default() in probe
2014-12-22 22:16 ` [PATCH 3/3] net: ieee802154: " Wolfram Sang
[not found] ` <CAEUmHyYbPbeWzHEaPYFAV+wTGYqhz7pps6XEzNrK_jQm_HPKpg@mail.gmail.com>
@ 2014-12-30 6:17 ` Marcel Holtmann
1 sibling, 0 replies; 6+ messages in thread
From: Marcel Holtmann @ 2014-12-30 6:17 UTC (permalink / raw)
To: Wolfram Sang
Cc: Linux Kernel Mailing List, linux-gpio, Varka Bhadram,
Alexander Aring, linux-wpan, netdev
Hi Wolfram,
> Since commit ab78029ecc34 (drivers/pinctrl: grab default handles from device
> core), we can rely on device core for setting the default pins.
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
> drivers/net/ieee802154/cc2520.c | 7 -------
> 1 file changed, 7 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-12-30 6:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-22 22:16 [PATCH 1/3] gpu: drm: tilcdc: don't use devm_pinctrl_get_select_default() in probe Wolfram Sang
2014-12-22 22:16 ` [PATCH 2/3] mmc: host: " Wolfram Sang
2014-12-23 15:37 ` Ulf Hansson
2014-12-22 22:16 ` [PATCH 3/3] net: ieee802154: " Wolfram Sang
[not found] ` <CAEUmHyYbPbeWzHEaPYFAV+wTGYqhz7pps6XEzNrK_jQm_HPKpg@mail.gmail.com>
2014-12-23 0:28 ` Varka Bhadram
2014-12-30 6:17 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).