* [PATCH gpio] gpio-amd8111: check ioport_map return value
@ 2014-12-29 8:39 Varka Bhadram
2015-01-07 3:21 ` Varka Bhadram
2015-01-14 12:31 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Varka Bhadram @ 2014-12-29 8:39 UTC (permalink / raw)
To: linux-gpio; +Cc: linus.walleij, Varka Bhadram
ioport_map() may fail. Its safe to check the return value.
Signed-off-by: Varka Bhadram <varkab@cdac.in>
---
drivers/gpio/gpio-amd8111.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpio/gpio-amd8111.c b/drivers/gpio/gpio-amd8111.c
index 3c09f1a6..a0585c3 100644
--- a/drivers/gpio/gpio-amd8111.c
+++ b/drivers/gpio/gpio-amd8111.c
@@ -213,6 +213,11 @@ found:
goto out;
}
gp.pm = ioport_map(gp.pmbase + PMBASE_OFFSET, PMBASE_SIZE);
+ if (!gp.pm) {
+ dev_err(&pdev->dev, "Couldn't map io port into io memory\n");
+ err = -ENOMEM;
+ goto out;
+ }
gp.pdev = pdev;
gp.chip.dev = &pdev->dev;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH gpio] gpio-amd8111: check ioport_map return value
2014-12-29 8:39 [PATCH gpio] gpio-amd8111: check ioport_map return value Varka Bhadram
@ 2015-01-07 3:21 ` Varka Bhadram
2015-01-14 12:31 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Varka Bhadram @ 2015-01-07 3:21 UTC (permalink / raw)
To: linux-gpio@vger.kernel.org; +Cc: Linus Walleij, Varka Bhadram
Ping ..?
On Mon, Dec 29, 2014 at 2:09 PM, Varka Bhadram <varkabhadram@gmail.com> wrote:
> ioport_map() may fail. Its safe to check the return value.
>
> Signed-off-by: Varka Bhadram <varkab@cdac.in>
> ---
> drivers/gpio/gpio-amd8111.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpio/gpio-amd8111.c b/drivers/gpio/gpio-amd8111.c
> index 3c09f1a6..a0585c3 100644
> --- a/drivers/gpio/gpio-amd8111.c
> +++ b/drivers/gpio/gpio-amd8111.c
> @@ -213,6 +213,11 @@ found:
> goto out;
> }
> gp.pm = ioport_map(gp.pmbase + PMBASE_OFFSET, PMBASE_SIZE);
> + if (!gp.pm) {
> + dev_err(&pdev->dev, "Couldn't map io port into io memory\n");
> + err = -ENOMEM;
> + goto out;
> + }
> gp.pdev = pdev;
> gp.chip.dev = &pdev->dev;
>
> --
> 1.7.9.5
>
--
Thanks and Regards,
Varka Bhadram.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH gpio] gpio-amd8111: check ioport_map return value
2014-12-29 8:39 [PATCH gpio] gpio-amd8111: check ioport_map return value Varka Bhadram
2015-01-07 3:21 ` Varka Bhadram
@ 2015-01-14 12:31 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2015-01-14 12:31 UTC (permalink / raw)
To: Varka Bhadram; +Cc: linux-gpio@vger.kernel.org, Varka Bhadram
On Mon, Dec 29, 2014 at 9:39 AM, Varka Bhadram <varkabhadram@gmail.com> wrote:
> ioport_map() may fail. Its safe to check the return value.
>
> Signed-off-by: Varka Bhadram <varkab@cdac.in>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-14 12:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-29 8:39 [PATCH gpio] gpio-amd8111: check ioport_map return value Varka Bhadram
2015-01-07 3:21 ` Varka Bhadram
2015-01-14 12:31 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).