* [PATCH] gpiolib: of: Correct error handling in of_get_named_gpiod_flags
@ 2015-01-09 8:40 Hans Holmberg
2015-01-14 5:39 ` Alexandre Courbot
2015-01-15 17:32 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Hans Holmberg @ 2015-01-09 8:40 UTC (permalink / raw)
To: Linus Walleij, Alexandre Courbot; +Cc: linux-gpio, Hans Holmberg
of_get_named_gpiod_flags fails with -EPROBE_DEFER in cases
where the gpio chip is available and the GPIO translation fails.
This causes drivers to be re-probed erroneusly, and hides the
real problem(i.e. the GPIO number being out of range).
Signed-off-by: Hans Holmberg <hans.holmberg@intel.com>
---
drivers/gpio/gpiolib-of.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
index 604dbe6..08261f2 100644
--- a/drivers/gpio/gpiolib-of.c
+++ b/drivers/gpio/gpiolib-of.c
@@ -45,8 +45,14 @@ static int of_gpiochip_find_and_xlate(struct gpio_chip *gc, void *data)
return false;
ret = gc->of_xlate(gc, &gg_data->gpiospec, gg_data->flags);
- if (ret < 0)
- return false;
+ if (ret < 0) {
+ /* We've found the gpio chip, but the translation failed.
+ * Return true to stop looking and return the translation
+ * error via out_gpio
+ */
+ gg_data->out_gpio = ERR_PTR(ret);
+ return true;
+ }
gg_data->out_gpio = gpiochip_get_desc(gc, ret);
return true;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] gpiolib: of: Correct error handling in of_get_named_gpiod_flags
2015-01-09 8:40 [PATCH] gpiolib: of: Correct error handling in of_get_named_gpiod_flags Hans Holmberg
@ 2015-01-14 5:39 ` Alexandre Courbot
2015-01-15 17:32 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Courbot @ 2015-01-14 5:39 UTC (permalink / raw)
To: Hans Holmberg; +Cc: Linus Walleij, linux-gpio@vger.kernel.org
On Fri, Jan 9, 2015 at 5:40 PM, Hans Holmberg <hans.holmberg@intel.com> wrote:
> of_get_named_gpiod_flags fails with -EPROBE_DEFER in cases
> where the gpio chip is available and the GPIO translation fails.
>
> This causes drivers to be re-probed erroneusly, and hides the
> real problem(i.e. the GPIO number being out of range).
>
> Signed-off-by: Hans Holmberg <hans.holmberg@intel.com>
> ---
> drivers/gpio/gpiolib-of.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
> index 604dbe6..08261f2 100644
> --- a/drivers/gpio/gpiolib-of.c
> +++ b/drivers/gpio/gpiolib-of.c
> @@ -45,8 +45,14 @@ static int of_gpiochip_find_and_xlate(struct gpio_chip *gc, void *data)
> return false;
>
> ret = gc->of_xlate(gc, &gg_data->gpiospec, gg_data->flags);
> - if (ret < 0)
> - return false;
> + if (ret < 0) {
> + /* We've found the gpio chip, but the translation failed.
> + * Return true to stop looking and return the translation
> + * error via out_gpio
> + */
> + gg_data->out_gpio = ERR_PTR(ret);
> + return true;
> + }
Nice catch.
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gpiolib: of: Correct error handling in of_get_named_gpiod_flags
2015-01-09 8:40 [PATCH] gpiolib: of: Correct error handling in of_get_named_gpiod_flags Hans Holmberg
2015-01-14 5:39 ` Alexandre Courbot
@ 2015-01-15 17:32 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2015-01-15 17:32 UTC (permalink / raw)
To: Hans Holmberg; +Cc: Alexandre Courbot, linux-gpio@vger.kernel.org
On Fri, Jan 9, 2015 at 9:40 AM, Hans Holmberg <hans.holmberg@intel.com> wrote:
> of_get_named_gpiod_flags fails with -EPROBE_DEFER in cases
> where the gpio chip is available and the GPIO translation fails.
>
> This causes drivers to be re-probed erroneusly, and hides the
> real problem(i.e. the GPIO number being out of range).
>
> Signed-off-by: Hans Holmberg <hans.holmberg@intel.com>
Patch applied for fixes with Alex's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-15 17:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-09 8:40 [PATCH] gpiolib: of: Correct error handling in of_get_named_gpiod_flags Hans Holmberg
2015-01-14 5:39 ` Alexandre Courbot
2015-01-15 17:32 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).