From: Paul Bolle <pebolle@tiscali.nl>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: "Valentin Rothberg" <valentinrothberg@gmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Alexandre Courbot" <gnurou@gmail.com>,
"Michal Simek" <michal.simek@xilinx.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 3/7] gpio/xilinx: Add support for X86 Arch
Date: Tue, 13 Jan 2015 10:20:25 +0100 [thread overview]
Message-ID: <1421140825.22660.85.camel@x220> (raw)
In-Reply-To: <CAPybu_1DRCuJFGsw6p2pqZLDXjp=fAD_i-Yj6+7GX-Vr++fpOA@mail.gmail.com>
Hi Ricardo,
On Tue, 2015-01-13 at 10:04 +0100, Ricardo Ribalda Delgado wrote:
> Thanks for noticing
>
> Shall I send the patch or you want to do it yourself?
I rather prefer you do it, even if it looks trivial.
Changing that line to
[...] || X86)
will apparently enable a bit of code for the first time on x86. Code
that I know nothing about. I don't even know how to build or test it.
See, I've submitted such obviously correct and trivial changes before,
only to receive fan mail from the kbuild test robot the very next day. I
hope to not repeat that experience.
Paul Bolle
next prev parent reply other threads:[~2015-01-13 9:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 15:51 [PATCH v5 0/7]gpio/xilinx: Add support for PCI mapped devices and rmmod Ricardo Ribalda Delgado
2014-12-17 15:51 ` [PATCH v5 1/7] gpio/xilinx: Remove offset property Ricardo Ribalda Delgado
2015-01-12 9:20 ` Linus Walleij
2014-12-17 15:51 ` [PATCH v5 2/7] gpio/xilinx: Convert the driver to platform device interface Ricardo Ribalda Delgado
2015-01-12 9:21 ` Linus Walleij
2014-12-17 15:51 ` [PATCH v5 3/7] gpio/xilinx: Add support for X86 Arch Ricardo Ribalda Delgado
2015-01-12 9:24 ` Linus Walleij
2015-01-12 9:31 ` Ricardo Ribalda Delgado
2015-01-13 9:02 ` Paul Bolle
2015-01-13 9:04 ` Ricardo Ribalda Delgado
2015-01-13 9:20 ` Paul Bolle [this message]
2015-01-15 16:13 ` Linus Walleij
2014-12-17 15:51 ` [PATCH v5 4/7] gpio/xilinx: Fix kernel-doc Ricardo Ribalda Delgado
2015-01-12 9:25 ` Linus Walleij
2014-12-17 15:51 ` [PATCH v5 5/7] gpio/xilinx: Create a single gpio chip on dual cores Ricardo Ribalda Delgado
2015-01-12 9:27 ` Linus Walleij
2014-12-17 15:51 ` [PATCH v5 6/7] gpio/gpiolib-of: Create of_mm_gpiochip_remove Ricardo Ribalda Delgado
2015-01-12 9:30 ` Linus Walleij
2015-01-12 9:31 ` Ricardo Ribalda Delgado
2015-01-12 9:33 ` Linus Walleij
2014-12-17 15:51 ` [PATCH v5 7/7] gpio/xilinx: Use of_mm_gpiochip_remove Ricardo Ribalda Delgado
2015-01-12 9:31 ` Linus Walleij
2015-01-01 15:27 ` [PATCH v5 0/7]gpio/xilinx: Add support for PCI mapped devices and rmmod Ricardo Ribalda Delgado
2015-01-12 9:32 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421140825.22660.85.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=ricardo.ribalda@gmail.com \
--cc=soren.brinkmann@xilinx.com \
--cc=valentinrothberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).