* [PATCH] gpio: gpio-dln2: Added a Blank line after declaration
@ 2015-01-13 15:09 Mohammad Jamal
2015-01-15 17:20 ` Linus Walleij
0 siblings, 1 reply; 5+ messages in thread
From: Mohammad Jamal @ 2015-01-13 15:09 UTC (permalink / raw)
To: linus.walleij, gnurou, linux-gpio, linux-kernel; +Cc: Mohammad Jamal
Fix the coding style issue by adding a blank line after declaration
Signed-off-by: Mohammad Jamal <md.jamalmohiuddin@gmail.com>
---
drivers/gpio/gpio-dln2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-dln2.c b/drivers/gpio/gpio-dln2.c
index ce3c155..dbdb4de 100644
--- a/drivers/gpio/gpio-dln2.c
+++ b/drivers/gpio/gpio-dln2.c
@@ -396,6 +396,7 @@ static void dln2_gpio_event(struct platform_device *pdev, u16 echo,
const void *data, int len)
{
int pin, irq;
+
const struct {
__le16 count;
__u8 type;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] gpio: gpio-dln2: Added a Blank line after declaration
2015-01-13 15:09 [PATCH] gpio: gpio-dln2: Added a Blank line after declaration Mohammad Jamal
@ 2015-01-15 17:20 ` Linus Walleij
2015-01-15 18:10 ` Johan Hovold
0 siblings, 1 reply; 5+ messages in thread
From: Linus Walleij @ 2015-01-15 17:20 UTC (permalink / raw)
To: Mohammad Jamal
Cc: Alexandre Courbot, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
On Tue, Jan 13, 2015 at 4:09 PM, Mohammad Jamal
<md.jamalmohiuddin@gmail.com> wrote:
> Fix the coding style issue by adding a blank line after declaration
>
> Signed-off-by: Mohammad Jamal <md.jamalmohiuddin@gmail.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gpio: gpio-dln2: Added a Blank line after declaration
2015-01-15 17:20 ` Linus Walleij
@ 2015-01-15 18:10 ` Johan Hovold
2015-01-16 4:52 ` Jamal Mohammad
0 siblings, 1 reply; 5+ messages in thread
From: Johan Hovold @ 2015-01-15 18:10 UTC (permalink / raw)
To: Linus Walleij
Cc: Mohammad Jamal, Alexandre Courbot, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
On Thu, Jan 15, 2015 at 06:20:43PM +0100, Linus Walleij wrote:
> On Tue, Jan 13, 2015 at 4:09 PM, Mohammad Jamal
> <md.jamalmohiuddin@gmail.com> wrote:
>
> > Fix the coding style issue by adding a blank line after declaration
> >
> > Signed-off-by: Mohammad Jamal <md.jamalmohiuddin@gmail.com>
>
> Patch applied.
This one looks bogus; it's adding a random newline within the
declarations not after.
Johan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gpio: gpio-dln2: Added a Blank line after declaration
2015-01-15 18:10 ` Johan Hovold
@ 2015-01-16 4:52 ` Jamal Mohammad
2015-01-16 8:51 ` Johan Hovold
0 siblings, 1 reply; 5+ messages in thread
From: Jamal Mohammad @ 2015-01-16 4:52 UTC (permalink / raw)
To: Johan Hovold
Cc: Linus Walleij, Alexandre Courbot, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
I think you are write ... checkpatch.pl was giving the error at the
line so i added a blank line... i will send an updated patch..
On Thu, Jan 15, 2015 at 11:40 PM, Johan Hovold <johan@kernel.org> wrote:
> On Thu, Jan 15, 2015 at 06:20:43PM +0100, Linus Walleij wrote:
>> On Tue, Jan 13, 2015 at 4:09 PM, Mohammad Jamal
>> <md.jamalmohiuddin@gmail.com> wrote:
>>
>> > Fix the coding style issue by adding a blank line after declaration
>> >
>> > Signed-off-by: Mohammad Jamal <md.jamalmohiuddin@gmail.com>
>>
>> Patch applied.
>
> This one looks bogus; it's adding a random newline within the
> declarations not after.
>
> Johan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-01-16 8:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-13 15:09 [PATCH] gpio: gpio-dln2: Added a Blank line after declaration Mohammad Jamal
2015-01-15 17:20 ` Linus Walleij
2015-01-15 18:10 ` Johan Hovold
2015-01-16 4:52 ` Jamal Mohammad
2015-01-16 8:51 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).