gpio: ARCH_MB86S7X?

gpio: ARCH_MB86S7X?

[Paul Bolle]

Jassi,

Your commit 0da094d82c27 ("gpio: Add Fujitsu MB86S7x GPIO driver") is
included in today's linux-next (ie, next-20150123). I noticed because a
script I use to check linux-next spotted a problem in it.

That commit added the Kconfig symbol GPIO_MB86S7X and made it depend on
ARCH_MB86S7X. But there's no Kconfig symbol ARCH_MB86S7X in linux-next.
I assume a patch to add that symbol is queued somewhere. Is that
correct?

Please note that I actually managed to cross-compile
drivers/gpio/gpio-mb86s7x.c with this command:
    make ARCH=arm CROSS_COMPILE=arm-linux-gnu- EXTRA_CFLAGS="-DCONFIG_GPIOLIB=y" drivers/gpio/gpio-mb86s7x.o

So, for what it's worth, that dependency appears to be not needed to
build this driver.

Thanks,


Paul Bolle

Re: gpio: ARCH_MB86S7X?

[Jassi Brar]

Hi Paul,

On 23 January 2015 at 15:51, Paul Bolle <pebolle@tiscali.nl> wrote:
> Jassi,
>
> Your commit 0da094d82c27 ("gpio: Add Fujitsu MB86S7x GPIO driver") is
> included in today's linux-next (ie, next-20150123). I noticed because a
> script I use to check linux-next spotted a problem in it.
>
> That commit added the Kconfig symbol GPIO_MB86S7X and made it depend on
> ARCH_MB86S7X. But there's no Kconfig symbol ARCH_MB86S7X in linux-next.
> I assume a patch to add that symbol is queued somewhere. Is that
> correct?
>
We are adding support for new Fujitsu platform MB86S7x. v4 of the
patchset has been submitted, we are hoping it gets upstream coming
merge window. However, the arch patches haven't been picked so far.

> Please note that I actually managed to cross-compile
> drivers/gpio/gpio-mb86s7x.c with this command:
>     make ARCH=arm CROSS_COMPILE=arm-linux-gnu- EXTRA_CFLAGS="-DCONFIG_GPIOLIB=y" drivers/gpio/gpio-mb86s7x.o
>
> So, for what it's worth, that dependency appears to be not needed to
> build this driver.
>
Linus.W, what do you suggest? Just drop the dependency?

Thanks
-Jassi

Re: gpio: ARCH_MB86S7X?

[Linus Walleij]

On Fri, Jan 23, 2015 at 11:34 AM, Jassi Brar <jaswinder.singh@linaro.org> wrote:
> On 23 January 2015 at 15:51, Paul Bolle <pebolle@tiscali.nl> wrote:

>> So, for what it's worth, that dependency appears to be not needed to
>> build this driver.
>>
> Linus.W, what do you suggest? Just drop the dependency?

Nah, not right now atleast. As there is a plan to get the platform
in it will just cause trouble.

What we can do is to say that it will be available also for
CONFIG_COMPILE_TEST, so it gets built on the servers
etc.

depends on ARCH_MB86S7X || COMPILE_TEST

But then you better test it a lot because then it will be
compiled on X86_64 and such.

Yours,
Linus Walleij

Re: gpio: ARCH_MB86S7X?

[Paul Bolle]

On Fri, 2015-01-23 at 11:55 +0100, Linus Walleij wrote:
> On Fri, Jan 23, 2015 at 11:34 AM, Jassi Brar <jaswinder.singh@linaro.org> wrote:
> > On 23 January 2015 at 15:51, Paul Bolle <pebolle@tiscali.nl> wrote:
> 
> >> So, for what it's worth, that dependency appears to be not needed to
> >> build this driver.
> >>
> > Linus.W, what do you suggest? Just drop the dependency?
> 
> Nah, not right now atleast. As there is a plan to get the platform
> in it will just cause trouble.
> 
> What we can do is to say that it will be available also for
> CONFIG_COMPILE_TEST, so it gets built on the servers
> etc.
> 
> depends on ARCH_MB86S7X || COMPILE_TEST
> 
> But then you better test it a lot because then it will be
> compiled on X86_64 and such.

Whatever you do, I won't be bothering you again about this. Unless
ARCH_MB86S7X takes a long time to land, that is.


Paul Bolle