* [PATCH] gpio: mpc8xxx: remove __initdata annotation for mpc8xxx_gpio_ids[]
@ 2015-02-12 6:52 Kevin Hao
2015-03-05 9:52 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Hao @ 2015-02-12 6:52 UTC (permalink / raw)
To: Linus Walleij, Alexandre Courbot; +Cc: linux-gpio
Since commit 98686d9a52ee ("gpio: mpc8xxx: Convert to platform device
interface"), we get the following section mismatch warning. Remove the
__initdata annotation to fix it.
WARNING: vmlinux.o(.data+0xbc28): Section mismatch in reference from the variable mpc8xxx_plat_driver to the variable .init.data:mpc8xxx_gpio_ids
The variable mpc8xxx_plat_driver references
the variable __initdata mpc8xxx_gpio_ids
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
Signed-off-by: Kevin Hao <haokexin@gmail.com>
---
drivers/gpio/gpio-mpc8xxx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c
index a6952ba343a8..a65b75161aa4 100644
--- a/drivers/gpio/gpio-mpc8xxx.c
+++ b/drivers/gpio/gpio-mpc8xxx.c
@@ -334,7 +334,7 @@ static struct irq_domain_ops mpc8xxx_gpio_irq_ops = {
.xlate = irq_domain_xlate_twocell,
};
-static struct of_device_id mpc8xxx_gpio_ids[] __initdata = {
+static struct of_device_id mpc8xxx_gpio_ids[] = {
{ .compatible = "fsl,mpc8349-gpio", },
{ .compatible = "fsl,mpc8572-gpio", },
{ .compatible = "fsl,mpc8610-gpio", },
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] gpio: mpc8xxx: remove __initdata annotation for mpc8xxx_gpio_ids[]
2015-02-12 6:52 [PATCH] gpio: mpc8xxx: remove __initdata annotation for mpc8xxx_gpio_ids[] Kevin Hao
@ 2015-03-05 9:52 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2015-03-05 9:52 UTC (permalink / raw)
To: Kevin Hao; +Cc: Alexandre Courbot, linux-gpio@vger.kernel.org
On Thu, Feb 12, 2015 at 7:52 AM, Kevin Hao <haokexin@gmail.com> wrote:
> Since commit 98686d9a52ee ("gpio: mpc8xxx: Convert to platform device
> interface"), we get the following section mismatch warning. Remove the
> __initdata annotation to fix it.
> WARNING: vmlinux.o(.data+0xbc28): Section mismatch in reference from the variable mpc8xxx_plat_driver to the variable .init.data:mpc8xxx_gpio_ids
> The variable mpc8xxx_plat_driver references
> the variable __initdata mpc8xxx_gpio_ids
> If the reference is valid then annotate the
> variable with __init* or __refdata (see linux/init.h) or name the variable:
> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
>
> Signed-off-by: Kevin Hao <haokexin@gmail.com>
Patch applied for fixes.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-05 9:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-12 6:52 [PATCH] gpio: mpc8xxx: remove __initdata annotation for mpc8xxx_gpio_ids[] Kevin Hao
2015-03-05 9:52 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).