* [PATCH] pinctrl: update direction_output function of cherryview driver
@ 2015-03-03 10:13 qipeng.zha
2015-03-06 7:31 ` Zha, Qipeng
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: qipeng.zha @ 2015-03-03 10:13 UTC (permalink / raw)
To: linux-gpio; +Cc: linus.walleij, mika.westerberg, qipeng.zha, jason.cj.chen
From: "qipeng.zha" <qipeng.zha@intel.com>
>From the comments of gpiod_direction_output(), need to set @value
as initial output, so update the lowlevel routine to make it work.
Signed-off-by: jason.cj.chen<jason.cj.chen@intel.com>
Signed-off-by: qipeng.zha <qipeng.zha@intel.com>
---
drivers/pinctrl/intel/pinctrl-cherryview.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
index e9f8b39..ee6a6de 100644
--- a/drivers/pinctrl/intel/pinctrl-cherryview.c
+++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
@@ -1206,6 +1206,7 @@ static int chv_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
static int chv_gpio_direction_output(struct gpio_chip *chip, unsigned offset,
int value)
{
+ chv_gpio_set(chip, offset, value);
return pinctrl_gpio_direction_output(chip->base + offset);
}
--
1.8.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH] pinctrl: update direction_output function of cherryview driver
2015-03-03 10:13 [PATCH] pinctrl: update direction_output function of cherryview driver qipeng.zha
@ 2015-03-06 7:31 ` Zha, Qipeng
2015-03-09 10:29 ` Mika Westerberg
2015-03-10 8:02 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Zha, Qipeng @ 2015-03-06 7:31 UTC (permalink / raw)
To: linux-gpio@vger.kernel.org
Cc: linus.walleij@linaro.org, Westerberg, Mika, Chen, Jason CJ
Hi Linus
Are you checking to merge this patch, thanks:)
Best wishes
Qipeng
-----Original Message-----
From: Zha, Qipeng
Sent: Tuesday, March 03, 2015 6:13 PM
To: linux-gpio@vger.kernel.org
Cc: linus.walleij@linaro.org; Westerberg, Mika; Zha, Qipeng; Chen, Jason CJ
Subject: [PATCH] pinctrl: update direction_output function of cherryview driver
From: "qipeng.zha" <qipeng.zha@intel.com>
>From the comments of gpiod_direction_output(), need to set @value as initial output, so update the lowlevel routine to make it work.
Signed-off-by: jason.cj.chen<jason.cj.chen@intel.com>
Signed-off-by: qipeng.zha <qipeng.zha@intel.com>
---
drivers/pinctrl/intel/pinctrl-cherryview.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
index e9f8b39..ee6a6de 100644
--- a/drivers/pinctrl/intel/pinctrl-cherryview.c
+++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
@@ -1206,6 +1206,7 @@ static int chv_gpio_direction_input(struct gpio_chip *chip, unsigned offset) static int chv_gpio_direction_output(struct gpio_chip *chip, unsigned offset,
int value)
{
+ chv_gpio_set(chip, offset, value);
return pinctrl_gpio_direction_output(chip->base + offset); }
--
1.8.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] pinctrl: update direction_output function of cherryview driver
2015-03-03 10:13 [PATCH] pinctrl: update direction_output function of cherryview driver qipeng.zha
2015-03-06 7:31 ` Zha, Qipeng
@ 2015-03-09 10:29 ` Mika Westerberg
2015-03-10 8:02 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Mika Westerberg @ 2015-03-09 10:29 UTC (permalink / raw)
To: qipeng.zha; +Cc: linux-gpio, linus.walleij, jason.cj.chen, David Cohen
On Tue, Mar 03, 2015 at 06:13:22PM +0800, qipeng.zha wrote:
> From: "qipeng.zha" <qipeng.zha@intel.com>
>
> >From the comments of gpiod_direction_output(), need to set @value
> as initial output, so update the lowlevel routine to make it work.
>
> Signed-off-by: jason.cj.chen<jason.cj.chen@intel.com>
> Signed-off-by: qipeng.zha <qipeng.zha@intel.com>
Thanks for the fix.
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> drivers/pinctrl/intel/pinctrl-cherryview.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
> index e9f8b39..ee6a6de 100644
> --- a/drivers/pinctrl/intel/pinctrl-cherryview.c
> +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
> @@ -1206,6 +1206,7 @@ static int chv_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
> static int chv_gpio_direction_output(struct gpio_chip *chip, unsigned offset,
> int value)
> {
> + chv_gpio_set(chip, offset, value);
> return pinctrl_gpio_direction_output(chip->base + offset);
> }
>
> --
> 1.8.3.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] pinctrl: update direction_output function of cherryview driver
2015-03-03 10:13 [PATCH] pinctrl: update direction_output function of cherryview driver qipeng.zha
2015-03-06 7:31 ` Zha, Qipeng
2015-03-09 10:29 ` Mika Westerberg
@ 2015-03-10 8:02 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2015-03-10 8:02 UTC (permalink / raw)
To: qipeng.zha; +Cc: linux-gpio@vger.kernel.org, Westerberg, Mika, jason.cj.chen
On Tue, Mar 3, 2015 at 11:13 AM, qipeng.zha <qipeng.zha@intel.com> wrote:
> From: "qipeng.zha" <qipeng.zha@intel.com>
>
> From the comments of gpiod_direction_output(), need to set @value
> as initial output, so update the lowlevel routine to make it work.
>
> Signed-off-by: jason.cj.chen<jason.cj.chen@intel.com>
> Signed-off-by: qipeng.zha <qipeng.zha@intel.com>
Patch applied for fixes.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-10 8:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-03 10:13 [PATCH] pinctrl: update direction_output function of cherryview driver qipeng.zha
2015-03-06 7:31 ` Zha, Qipeng
2015-03-09 10:29 ` Mika Westerberg
2015-03-10 8:02 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).