From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Arnd Bergmann <arnd@arndb.de>,
srv_heupstream@mediatek.com,
Hongzhou Yang <hongzhou.yang@mediatek.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] pinctrl: mediatek: Adjust mt8173 pinctrl kconfig
Date: Mon, 9 Mar 2015 16:26:24 +0800 [thread overview]
Message-ID: <1425889584.4871.12.camel@mtksdaap41> (raw)
In-Reply-To: <1425639954.24292.274.camel@x220>
On Fri, 2015-03-06 at 12:05 +0100, Paul Bolle wrote:
> On Fri, 2015-03-06 at 14:24 +0800, Yingjoe Chen wrote:
> > --- a/drivers/pinctrl/mediatek/Kconfig
> > +++ b/drivers/pinctrl/mediatek/Kconfig
>
> > @@ -8,11 +8,13 @@ config PINCTRL_MTK_COMMON
> > select OF_GPIO
> >
> > config PINCTRL_MT8135
> > - def_bool MACH_MT8135
> > + def_bool MACH_MT8135 || COMPILE_TEST
> > select PINCTRL_MTK_COMMON
> >
> > config PINCTRL_MT8173
> > - def_bool MACH_MT8173
> > + bool "Mediatek MT8173 pin control"
> > + def_bool y
>
> The kconfig tools will do what you mean here, but I think it's cleaner
> to make this just:
> bool "Mediatek MT8173 pin control"
> default y
>
Hi Paul,
Just sent a new version with this change.
Thanks for your suggestion.
Joe.C
next prev parent reply other threads:[~2015-03-09 8:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 6:24 [PATCH 1/2] arm64: mediatek: Select PINCTRL for Mediatek platform Yingjoe Chen
2015-03-06 6:24 ` [PATCH 2/2] pinctrl: mediatek: Adjust mt8173 pinctrl kconfig Yingjoe Chen
2015-03-06 11:05 ` Paul Bolle
2015-03-09 8:26 ` Yingjoe Chen [this message]
2015-03-09 8:13 ` [PATCH] " Yingjoe Chen
2015-03-09 20:36 ` [PATCH 2/2] " Arnd Bergmann
2015-03-13 6:46 ` Yingjoe Chen
2015-03-13 10:08 ` Arnd Bergmann
2015-03-13 14:40 ` [PATCH v3] " Yingjoe Chen
2015-03-18 12:01 ` Linus Walleij
2015-03-06 13:18 ` [PATCH 1/2] arm64: mediatek: Select PINCTRL for Mediatek platform Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425889584.4871.12.camel@mtksdaap41 \
--to=yingjoe.chen@mediatek.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=hongzhou.yang@mediatek.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pebolle@tiscali.nl \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).