linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: linux-gpio@vger.kernel.org
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Lee Jones <lee.jones@linaro.org>,
	Raymond Tan <raymond.tan@intel.com>,
	"Ong, Boon Leong" <boon.leong.ong@intel.com>
Subject: Re: [PATCH v2 1/1] gpio: dwapb: enable for Quark
Date: Mon, 09 Mar 2015 17:28:33 +0200	[thread overview]
Message-ID: <1425914913.14897.235.camel@linux.intel.com> (raw)
In-Reply-To: <1425575153-19453-1-git-send-email-andriy.shevchenko@linux.intel.com>

On Thu, 2015-03-05 at 19:05 +0200, Andy Shevchenko wrote:
> The Intel Quark SoC contains the DW GPIO on board. While fixing the build error
> the commit 1972c97db5b0 (gpio: dwapb: fix compile errors) disables the
> possibility to build the driver on X86, i.e. Intel Quark.
> 
> The patch reenables it for Intel Quark as well.
> 
> Since we have Intel Quark SoC introduced in 4.0-rc1 I would like to make this
> fix available there as well, though the actual MFD driver [1] is not yet
> applied.

An update: the patch was applied by Lee. So, it would be nice to have
this one applied at least for future 4.1-rc1 if no objections.

> 
> [1] https://lkml.org/lkml/2015/2/1/217
> 
> Fixes: 1972c97db5b0 (gpio: dwapb: fix compile errors)
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> Changelog v2:
> - fix typo of parens location
>  drivers/gpio/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index c1e2ca3..6ba5464 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -148,8 +148,7 @@ config GPIO_GENERIC_PLATFORM
>  
>  config GPIO_DWAPB
>  	tristate "Synopsys DesignWare APB GPIO driver"
> -	depends on ARM
> -	depends on OF_GPIO
> +	depends on (ARM && OF_GPIO) || X86_INTEL_QUARK
>  	select GPIO_GENERIC
>  	select GENERIC_IRQ_CHIP
>  	help


-- 
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy


      reply	other threads:[~2015-03-09 15:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-05 17:05 [PATCH v2 1/1] gpio: dwapb: enable for Quark Andy Shevchenko
2015-03-09 15:28 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425914913.14897.235.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=boon.leong.ong@intel.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=raymond.tan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).