From: <grygorii.strashko@linaro.org>
To: Javier Martinez Canillas <javier@dowhile0.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
ssantosh@kernel.org, Kevin Hilman <khilman@deeprootsystems.com>,
tony@atomide.com
Cc: linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Grygorii Strashko <grygorii.strashko@linaro.org>
Subject: [PATCH 3/8] gpio: omap: convert debounce functions switch to use gpio offset
Date: Thu, 19 Mar 2015 19:25:39 +0200 [thread overview]
Message-ID: <1426785944-17255-4-git-send-email-grygorii.strashko@linaro.org> (raw)
In-Reply-To: <1426785944-17255-1-git-send-email-grygorii.strashko@linaro.org>
From: Grygorii Strashko <grygorii.strashko@linaro.org>
Convert debounce functions to use GPIO offset instead of system
GPIO numbers. This allows to drop unneeded conversations between
system GPIO <-> GPIO offset which are done in many places and
many times.
It is safe to do now because:
- gpiolib always passes GPIO offset to GPIO controller
- OMAP GPIO driver converted to use IRQ domain
This is preparation step before removing:
#define GPIO_INDEX(bank, gpio)
#define GPIO_BIT(bank, gpio)
int omap_irq_to_gpio()
Signed-off-by: Grygorii Strashko <grygorii.strashko@linaro.org>
---
drivers/gpio/gpio-omap.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index 7aeee7b..2df693b 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -208,13 +208,13 @@ static inline void omap_gpio_dbck_disable(struct gpio_bank *bank)
/**
* omap2_set_gpio_debounce - low level gpio debounce time
* @bank: the gpio bank we're acting upon
- * @gpio: the gpio number on this @gpio
+ * @offset: the gpio number on this @bank
* @debounce: debounce time to use
*
* OMAP's debounce time is in 31us steps so we need
* to convert and round up to the closest unit.
*/
-static void omap2_set_gpio_debounce(struct gpio_bank *bank, unsigned gpio,
+static void omap2_set_gpio_debounce(struct gpio_bank *bank, unsigned offset,
unsigned debounce)
{
void __iomem *reg;
@@ -231,7 +231,7 @@ static void omap2_set_gpio_debounce(struct gpio_bank *bank, unsigned gpio,
else
debounce = (debounce / 0x1f) - 1;
- l = GPIO_BIT(bank, gpio);
+ l = BIT(offset);
clk_prepare_enable(bank->dbck);
reg = bank->base + bank->regs->debounce;
@@ -266,16 +266,16 @@ static void omap2_set_gpio_debounce(struct gpio_bank *bank, unsigned gpio,
/**
* omap_clear_gpio_debounce - clear debounce settings for a gpio
* @bank: the gpio bank we're acting upon
- * @gpio: the gpio number on this @gpio
+ * @offset: the gpio number on this @bank
*
* If a gpio is using debounce, then clear the debounce enable bit and if
* this is the only gpio in this bank using debounce, then clear the debounce
* time too. The debounce clock will also be disabled when calling this function
* if this is the only gpio in the bank using debounce.
*/
-static void omap_clear_gpio_debounce(struct gpio_bank *bank, unsigned gpio)
+static void omap_clear_gpio_debounce(struct gpio_bank *bank, unsigned offset)
{
- u32 gpio_bit = GPIO_BIT(bank, gpio);
+ u32 gpio_bit = BIT(offset);
if (!bank->dbck_flag)
return;
@@ -659,7 +659,7 @@ static void omap_reset_gpio(struct gpio_bank *bank, int gpio)
omap_set_gpio_irqenable(bank, gpio, 0);
omap_clear_gpio_irqstatus(bank, gpio);
omap_set_gpio_triggering(bank, GPIO_INDEX(bank, gpio), IRQ_TYPE_NONE);
- omap_clear_gpio_debounce(bank, gpio);
+ omap_clear_gpio_debounce(bank, GPIO_INDEX(bank, gpio));
}
/* Use disable_irq_wake() and enable_irq_wake() functions from drivers */
--
1.9.1
next prev parent reply other threads:[~2015-03-19 17:25 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 17:25 [PATCH 0/8] gpio: omap: cleanup: get rid of system GPIO <-> GPIO offset converseations grygorii.strashko
2015-03-19 17:25 ` [PATCH 1/8] gpio: omap: convert omap_gpio_is_input() to use gpio offset grygorii.strashko
2015-03-20 16:42 ` santosh.shilimkar
2015-03-20 18:37 ` Javier Martinez Canillas
2015-03-19 17:25 ` [PATCH 2/8] gpio: omap: simplify omap_set_gpio_dataout_x() grygorii.strashko
2015-03-20 16:45 ` santosh.shilimkar
2015-03-20 18:40 ` Javier Martinez Canillas
2015-03-19 17:25 ` grygorii.strashko [this message]
2015-03-20 18:44 ` [PATCH 3/8] gpio: omap: convert debounce functions switch to use gpio offset Javier Martinez Canillas
2015-03-19 17:25 ` [PATCH 4/8] gpio: omap: drop 'gpio' param from omap_gpio_init_irq() grygorii.strashko
2015-03-20 18:46 ` Javier Martinez Canillas
2015-03-19 17:25 ` [PATCH 5/8] gpio: omap: convert gpio irq functions to use GPIO offset grygorii.strashko
2015-03-19 23:03 ` Tony Lindgren
2015-03-20 15:06 ` Grygorii.Strashko@linaro.org
2015-03-20 16:49 ` santosh.shilimkar
2015-03-20 18:47 ` Javier Martinez Canillas
2015-03-19 17:25 ` [PATCH 6/8] gpio: omap: get rid of GPIO_BIT() macro grygorii.strashko
2015-03-20 16:50 ` santosh.shilimkar
2015-03-20 18:48 ` Javier Martinez Canillas
2015-03-19 17:25 ` [RFT OMAP1 PATCH 7/8] gpio: omap: get rid of omap_irq_to_gpio() grygorii.strashko
2015-03-20 18:56 ` Javier Martinez Canillas
2015-03-20 20:39 ` Grygorii.Strashko@linaro.org
2015-03-20 23:44 ` Javier Martinez Canillas
2015-03-19 17:25 ` [RFT OMAP1 PATCH 8/8] gpio: omap: get rid of GPIO_INDEX() macro grygorii.strashko
2015-03-20 18:56 ` Javier Martinez Canillas
2015-03-19 23:00 ` [PATCH 0/8] gpio: omap: cleanup: get rid of system GPIO <-> GPIO offset converseations Tony Lindgren
2015-03-20 15:11 ` Grygorii.Strashko@linaro.org
2015-03-22 17:32 ` Aaro Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426785944-17255-4-git-send-email-grygorii.strashko@linaro.org \
--to=grygorii.strashko@linaro.org \
--cc=gnurou@gmail.com \
--cc=javier@dowhile0.org \
--cc=khilman@deeprootsystems.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=ssantosh@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).